Skip to content

Adding contributing.md #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

tanhauhau
Copy link
Member

Fixes:

@Rich-Harris need your thoughts especially on the coding conventions

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau
Copy link
Member Author

tanhauhau commented Oct 22, 2019

I used Docusaurus amazing contributing guide as a reference

@Rich-Harris Rich-Harris merged commit 33c8cd3 into sveltejs:master Oct 25, 2019
@Rich-Harris
Copy link
Member

I love this, thank you!

@tanhauhau tanhauhau deleted the tanhauhau/contributing-md branch October 25, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants