Skip to content

fix: don't resolve via svelte field for prebundled libraries #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 11, 2022

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Nov 3, 2022

so they actually get used

This pushes the svelte dependencies to optimizeDeps.include when prebundleSvelteLibraries is true so needs a bit more testing.

One sideeffect is that cold start of vite will be slower, but less restarts happen due to optimization being done earlier.

@benmccann
Copy link
Member

Wouldn't this be roughly equivalent to #459 for SvelteKit users?

@dominikg
Copy link
Member Author

dominikg commented Nov 4, 2022

No, this just prevents resolving dependencies via svelte field again after they have been prebundled. Which is a bug causing the prebundled dependencies not being used.

@bluwy bluwy merged commit 9dd08b1 into main Nov 11, 2022
@bluwy bluwy deleted the fix/prebundle-svelte-libraries branch November 11, 2022 15:30
@github-actions github-actions bot mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants