test: add tests for prebundleSvelteLibraries #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Nov 11, 2022
Comment on lines
+35
to
+37
| expect(optimizedPaths).toContain( | ||
| 'e2e-test-dep-svelte-nested > e2e-test-dep-svelte-simple > e2e-test-dep-cjs-only' | ||
| ); |
There was a problem hiding this comment.
This is failing as we don't do deep optimization when prebundleSvelteLibraries yet.
| optimizeDeps: { | ||
| // TODO this must be excluded because nested has an scss dep that prebundle can't handle! | ||
| // figure out how to exclude it automatically or at least tell the user about it in a more friendly way | ||
| exclude: ['e2e-test-dep-svelte-nested'], |
There was a problem hiding this comment.
Looks like a bug in Vite. Currently it externalizes .scss/.css etc files when prebundling, but looks like it's failing when it's a package that exports a .scss file. Replacing this as e2e-test-dep-scss-only should have the same effect
Comment on lines
+12
to
+14
| // TODO without this, it fails for module.exports in the browser. | ||
| // shouldn't prebundling take care of it? | ||
| 'e2e-test-dep-svelte-hybrid > e2e-test-dep-cjs-only' |
There was a problem hiding this comment.
Looks like this will be fixed by #482. The requests shows that it's not using the prebundled files.
There was a problem hiding this comment.
Here's a snippet of it
import Hybrid from '/@fs/Users/bjorn/Work/oss/vite-plugin-svelte/node_modules/.pnpm/file+packages+e2e-tests+_test_dependencies+svelte-hybrid/node_modules/e2e-test-dep-svelte-hybrid/index.js';
import Simple from '/@fs/Users/bjorn/Work/oss/vite-plugin-svelte/node_modules/.pnpm/file+packages+e2e-tests+_test_dependencies+svelte-simple/node_modules/e2e-test-dep-svelte-simple/index.js';
import { Message as Nested } from '/@fs/Users/bjorn/Work/oss/vite-plugin-svelte/node_modules/.pnpm/file+packages+e2e-tests+_test_dependencies+svelte-nested/node_modules/e2e-test-dep-svelte-nested/src/index.js';
import { setSomeContext } from '/node_modules/.vite/deps/e2e-test-dep-svelte-api-only.js?v=89f48f1a';
import { getContext } from '/node_modules/.vite/deps/svelte.js?v=89f48f1a';
const file = "src/App.svelte";
|
Tests merged into #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked the tests from #478 on main to compare the results