Skip to content

New file_io messages #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2015
Merged

New file_io messages #183

merged 4 commits into from
Jul 6, 2015

Conversation

mfine
Copy link
Contributor

@mfine mfine commented Jun 24, 2015

Remove bi-directionality. Request, response all the things. No deprecation necessary. Were there more changes to these messages we wanted? A dir_done message vs. the 0xff thing might be nice. Thoughts?

/cc @fnoble @mookerji @denniszollo

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/159/
Test PASSed.

denniszollo
denniszollo reviewed Jun 24, 2015
View reviewed changes
spec/yaml/swiftnav/sbp/file_io.yaml
type: u8
units: bytes
desc: Chunk size read
- filename:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the actual byte stream from the file. In keeping with the current design, you would get these fields + the rest of the 256 bytes with a portion of the file.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/160/
Test PASSed.

@mfine
Copy link
Contributor Author

mfine commented Jun 24, 2015

Contents fields added for both responses.

This was referenced Jun 24, 2015
Merged
Merged
Closed
@mfine mfine self-assigned this Jun 24, 2015
@mookerji
Copy link
Contributor

Instead of having a special message indicating that a response is done, what about using an empty response to indicate that a request is finished?

@mfine mfine mentioned this pull request Jun 30, 2015
Merged
@mfine
Copy link
Contributor Author

mfine commented Jul 6, 2015

Pending the firmware changes and a rebase, this should be ready to go. The comment around the contents has been addressed. There's already an existing signal to finish dir reading - 0xff, we'll just leave that.

@mfine
Copy link
Contributor Author

mfine commented Jul 6, 2015

Rebased.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/180/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/182/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/184/
Test PASSed.

@mfine
Copy link
Contributor Author

mfine commented Jul 6, 2015

Going to bring this in if there are no objections.

@mookerji
Copy link
Contributor

mookerji commented Jul 6, 2015

👍

mfine added a commit that referenced this pull request Jul 6, 2015
@mfine
Merge pull request #183 from mfine/mfine-file-io
5efddf1 
New file_io messages
@mfine mfine merged commit 5efddf1 into swift-nav:master Jul 6, 2015
@mfine mfine deleted the mfine-file-io branch July 6, 2015 20:07
RReichert added a commit that referenced this pull request May 19, 2025
@swiftnav-svc-jenkins @RReichert
Auto submodule update: cmake - Update protobuf to v25.1 (#183) (#1476)
975e1ab 
Automated PR by Jenkins. If CI has passed successfully, merge away!



**cmake**  8920f2a3  ->  361035b6
-  361035b6  :  Update protobuf to v25.1 (swift-nav/cmake#183)
- 5bf22f7d : Update CMake minimum required version to 3.13
(swift-nav/cmake#182)


This pull request was created by
https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/20021/.

---------

Co-authored-by: Rodrigo Reichert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfine mfine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfine @swiftnav-jenkins @mookerji @denniszollo