This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Disable this library for Swift 5.9 and above. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test this please |
|
For now, I've left this enabled on Windows, as Windows support isn't landed in the Swift runtime yet. |
|
@swift-server-bot add to allowlist |
|
@al45tair the CI test run with warnings as errors, so you may want to also conditionalize any test and sample code. note the CI jobs can be reproduced locally by invoking the same docker compose commands the CI job does |
al45tair
force-pushed
the
eng/PR-111109405
branch
from
5bed8f3 to
e75348f
Compare
|
@swift-server-bot test this please |
al45tair
force-pushed
the
eng/PR-111109405
branch
from
e75348f to
4fef46c
Compare
|
@swift-server-bot test this please |
Swift 5.9 has a new built-in backtrace-on-crash facility, which supersedes this library. rdar://111109405
al45tair
force-pushed
the
eng/PR-111109405
branch
from
4fef46c to
1d503b4
Compare
|
We'll want to hold off on merging this until swiftlang/swift#67483 and its 5.9 counterpart have gone through and the results have landed in a nightly. |
ktoso
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Thumbs up for merging this!
cc @tomerd @weissi @fabianfett :)
FranzBusch
approved these changes
Sep 5, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Sep 6, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vapor/vapor](https://togithub.com/vapor/vapor) | minor | `4.80.0` -> `4.81.0` | --- ### Release Notes <details> <summary>vapor/vapor (vapor/vapor)</summary> ### [`v4.81.0`](https://togithub.com/vapor/vapor/releases/tag/4.81.0): - The swift-backtrace library is no longer needed in 5.9 [Compare Source](https://togithub.com/vapor/vapor/compare/4.80.0...4.81.0) #### What's Changed The swift-backtrace library is no longer needed in 5.9 by [@​gwynne](https://togithub.com/gwynne) in [#​3064](https://togithub.com/vapor/vapor/issues/3064) > Per [https://github.com/swift-server/swift-backtrace/pull/68](https://togithub.com/swift-server/swift-backtrace/pull/68). ###### *This patch was released by [@​gwynne](https://togithub.com/gwynne)* **Full Changelog**: vapor/vapor@4.80.0...4.81.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
euanh
pushed a commit
to euanh/swift-backtrace
that referenced
this pull request
Jun 13, 2024
euanh
added a commit
to euanh/swift-backtrace
that referenced
this pull request
Jun 13, 2024
Pull request swift-server#68 prevents Backtrace from being built on Swift 5.9 and above, but Demangle is still built and fails when the importing project uses musl.
euanh
added a commit
to euanh/swift-backtrace
that referenced
this pull request
Jun 13, 2024
Pull request swift-server#68 prevents Backtrace from being built on Swift 5.9 and above, but Demangle is still built and fails when the importing project uses musl.
euanh
added a commit
to euanh/swift-backtrace
that referenced
this pull request
Jun 13, 2024
Pull request swift-server#68 prevents Backtrace from being built on Swift 5.9 and above, but Demangle is still built and fails when the importing project uses musl.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.9 has a new built-in backtrace-on-crash facility, which supersedes this library.
rdar://111109405