This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Do not build Demangle on Swift 5.9 or above #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem I ran into was similar to #71, but instead of making the library compatible with musl this change switches off the build on newer Swift versions, as #68 did for I added the conditional imports in |
FranzBusch
approved these changes
Jun 13, 2024
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
Hmmm we lost CI rights, @yim-lee do you think you could help? |
|
@swift-server-bot add to allowlist |
|
@FranzBusch @ktoso We need to do "add to allowlist" first. AFAIK no one can trigger a build if the CI doesn't recognize the PR author. Also, can one of you approve and merge #70 for Swift 5.10 CI please? |
|
Oh I'm silly and forgot that... Thank you @yim-lee -- merged the other thing |
Pull request swift-server#68 prevents Backtrace from being built on Swift 5.9 and above, but Demangle is still built and fails when the importing project uses musl.
euanh
force-pushed
the
do-not-build-demangle-after-5.9
branch
from
0843703 to
d4f33e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #68 prevents Backtrace from being built on Swift 5.9 and above, but Demangle is still built and fails when the importing project uses musl.