Implement Structured MemcachedError for Enhanced Error Handling#33
Merged
FranzBusch merged 18 commits intoswift-server:mainfrom Aug 18, 2023
Merged
Implement Structured MemcachedError for Enhanced Error Handling#33FranzBusch merged 18 commits intoswift-server:mainfrom
FranzBusch merged 18 commits intoswift-server:mainfrom
Conversation
dkz2
force-pushed
the
Implement-MemcachedError
branch
from
dc1fa42 to
ea8a16a
Compare
FranzBusch
reviewed
Aug 12, 2023
Contributor
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
Looks good overall. Left some nits around what errors we throw where.
| throw MemcachedConnectionError.connectionShutdown | ||
| throw MemcachedError( | ||
| code: .connectionShutdown, | ||
| message: "The connection to the Memcached server has shut down.", |
Contributor
There was a problem hiding this comment.
Suggested change
| message: "The connection to the Memcached server has shut down.", | |
| message: "The connection to the Memcached server has been shut down.", |
| } | ||
| } | ||
|
|
||
| /// A high-level error code to provide broad a classification. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// A high-level error code to provide broad a classification. | |
| /// A high-level error code to provide a broad classification. |
Comment on lines
+159
to
+160
| /// Indicates that a nil response was received from the server. | ||
| case unexpectedNilResponse |
Contributor
There was a problem hiding this comment.
I don't think we should expose this publicly and we should double check when we actually throw this. This really should only happen when the inboundStream returns us nil. In that case we should just throw connectionShutdown
| code: .connectionShutdown, | ||
| message: "The connection to the Memcached server has shut down.", | ||
| cause: nil, | ||
| location: MemcachedError.SourceLocation.here() |
Contributor
There was a problem hiding this comment.
NIT: (Everywhere please)
Suggested change
| location: MemcachedError.SourceLocation.here() | |
| location: .here() |
| /// - key: The key for the value to decrement. | ||
| /// - amount: The `Int` amount to decrement the value by. Must be larger than 0. | ||
| /// - Throws: A `MemcachedConnectionError` if the connection to the Memcached server is shut down. | ||
| /// - Throws: A `MemcachedError` with the code `.connectionShutdown` if the connection to the Memcache server is shut down. |
Contributor
There was a problem hiding this comment.
Let's just put that comment everywhere
Suggested change
| /// - Throws: A `MemcachedError` with the code `.connectionShutdown` if the connection to the Memcache server is shut down. | |
| /// - Throws: A `MemcachedError` that indicates the failure. |
Comment on lines
+313
to
+314
| code: .unexpectedNilResponse, | ||
| message: "Received an unexpected nil response from the Memcached server.", |
Contributor
There was a problem hiding this comment.
Suggested change
| code: .unexpectedNilResponse, | |
| message: "Received an unexpected nil response from the Memcached server.", | |
| code: .protocolError, | |
| message: "Received an unexpected return code \(response.returnCode) for a delete request.", |
| /// - Throws: A `MemcachedConnectionError.connectionShutdown` error if the connection to the Memcache server is shut down. | ||
| /// - Throws: A `MemcachedConnectionError.unexpectedNilResponse` error if the key was not found or if an unexpected response code was returned. | ||
| /// - Throws: A `MemcachedError` with the code `.connectionShutdown` if the connection to the Memcache server is shut down. | ||
| /// - Throws: A `MemcachedError` with the code `.keyNotFound` if the key was not found. |
Contributor
There was a problem hiding this comment.
This is good to document!
| /// - Throws: A `MemcachedConnectionError.keyExist` if the key already exists in the Memcached server. | ||
| /// - Throws: A `MemcachedConnectionError.unexpectedNilResponse` if an unexpected response code is returned. | ||
| /// - Throws: A `MemcachedError` with the code `.connectionShutdown` if the connection to the Memcache server is shut down. | ||
| /// - Throws: A `MemcachedError` with the code `.keyExist` if the key already exist. |
Contributor
There was a problem hiding this comment.
This is also good to document!
Comment on lines
+440
to
+441
| code: .unexpectedNilResponse, | ||
| message: "Received an unexpected nil response from the Memcached server.", |
Contributor
There was a problem hiding this comment.
Same as above please with the unexpected return code
Comment on lines
+495
to
+496
| code: .unexpectedNilResponse, | ||
| message: "Received an unexpected nil response from the Memcached server.", |
FranzBusch
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
MemcachedErrorstructure to provide a more structured and intuitive error handling mechanism. This aligns error handled with best practices from the SwiftNIO community, ensuring developers can quickly identify the Nate and origin of any errors.Motivation:
Adopting a more structured error handling mechanism empowers developers with clearer insights into errors. Moving away from string descriptions towards a type that retains detailed information about the error will enhance the overall developer experience.
Modifications:
MemcachedErrorstructure, containing a Code type for high-level error kinds and detailed descriptions, including the error message, cause, and exact source location.MemcachedConnectionErrorand integrated its case errors intoMemcachedErrorfor a unified error handling approach.MemcachedConnectionthat previously usedMemcachedConnectionErrorto now leverageMemcachedError.getBufferAllocatormethod inMemcachedConnectionto abstract buffer allocation based on the actor's state, making code more concise and readable.MemcachedConnectionfor cleaner and more maintainable code.Results:
With the structured
MemcachedError, our API provides developers with a more comprehensive understanding of errors, ensuring that issues can be identified and addresses more efficiently.