OrderedImports should create separate group for @_implementationOnly … #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebgraham
requested review from
ahoppen,
allevato,
bnbarham and
shawnhyam
as code owners
|
We should have the swift-syntax PR ready to be merged before this one is merged and then merge this PR and the swift-syntax PR at the same time. Edit: Actually, the formatting of swift-syntax is checked against the latest released Swift toolchain, so swift-syntax doesn’t need to be updated. So, we should be good to merge this one. |
allevato
reviewed
May 7, 2025
api-breakages.txt
Outdated
| @@ -18,3 +18,4 @@ API breakage: func Configuration.MultilineStringReflowBehavior.hash(into:) has b | |||
| API breakage: func Configuration.MultilineStringReflowBehavior.encode(to:) has been removed | |||
| API breakage: var Configuration.MultilineStringReflowBehavior.hashValue has been removed | |||
| API breakage: constructor Configuration.MultilineStringReflowBehavior.init(from:) has been removed | |||
| API breakage: enum LineType.implementationOnlyImport has been added as a new enum case | |||
There was a problem hiding this comment.
This check is still failing; the message needs to be copied verbatim from the error in the CI log:
API breakage: enumelement LineType.implementationOnlyImport has been added as a new enum case
(enumelement, not enum)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OrderedImports rule should create a separate import grouping for
@_implementationOnlyimports to go with the current@testablegroup. The code is refactored a bit to enable a future change for public/internal/private import grouping, and to harden again other import attributes like @preconcurrency.Discussed in #703.