Skip to content

Make swift-syntax build in Swift 6 language mode #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 25, 2024

rdar://125579439

@ahoppen ahoppen requested a review from bnbarham as a code owner March 25, 2024 23:15
@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from b545734 to 94a0095 Compare March 26, 2024 23:19
@ahoppen ahoppen changed the title Make swift-syntax build in Swift 6 language mode 🚥 #2558 Make swift-syntax build in Swift 6 language mode Mar 26, 2024
@ahoppen
Copy link
Member Author

ahoppen commented Mar 26, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch 2 times, most recently from 3688dcb to 702555b Compare March 27, 2024 09:54
@ahoppen
Copy link
Member Author

ahoppen commented Mar 27, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 28, 2024

Currently blocked because URL and stderr are not Sendable on Linux.

@ahoppen ahoppen marked this pull request as draft March 28, 2024 21:46
@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from 702555b to c036de6 Compare April 16, 2024 05:11
@ahoppen ahoppen marked this pull request as ready for review April 16, 2024 05:12
@ahoppen
Copy link
Member Author

ahoppen commented Apr 16, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 16, 2024

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from c036de6 to 37cd14d Compare April 20, 2024 04:58
@ahoppen
Copy link
Member Author

ahoppen commented Apr 20, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 20, 2024

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from 37cd14d to 8bf9718 Compare April 22, 2024 21:45
@ahoppen ahoppen requested a review from DougGregor as a code owner April 22, 2024 21:45
@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2024

@swift-ci Please test Windows

ahoppen added 2 commits April 22, 2024 16:43
Otherwise we get errors `ambiguous implicit access level for import` if one file imports a module as `public` and another file imports it without access modifiers.
@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from 8bf9718 to 8b5ceda Compare April 22, 2024 23:51
@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2024

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/build-in-swift-6-language-mode branch from 8b5ceda to fc47c7b Compare April 23, 2024 05:51
@ahoppen
Copy link
Member Author

ahoppen commented Apr 23, 2024

@swift-ci Please test

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Apr 23, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 23, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 431475e into swiftlang:main Apr 23, 2024
3 checks passed
@ahoppen ahoppen deleted the ahoppen/build-in-swift-6-language-mode branch April 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants