[6.0] Make swift-syntax build in Swift 6 language mode #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Apr 25, 2024
ahoppen
commented
- Explanation: This makes swift-syntax build in Swift 6 mode when using a Swift 6 compiler
- Scope: The Swift package build of swift-syntax. The CMake build is unaffected
- Risk: All possible issues caused by this will be found at build time
- Testing: Tested that swift-syntax builds without warnings with both a Swift 5 and Swift 6 compiler
- Issue: rdar://125579439
- Reviewer: @bnbarham on Make swift-syntax build in Swift 6 language mode #2568 and Enable Swift 6 mode unless we are in a self-hosted Swift CI job #2621
Otherwise we get errors `ambiguous implicit access level for import` if one file imports a module as `public` and another file imports it without access modifiers.
We disable Swift 6 mode when the `SWIFTCI_IS_SELF_HOSTED` environment variable is set to work around the following issue: The self-hosted SwiftPM job has Xcode 15.3 (Swift 5.10) installed and builds a Swift 6 SwiftPM from source. It then tries to build itself as a fat binary using the just-built Swift 6 SwiftPM, which uses xcbuild from Xcode as the build system. But the xcbuild in the installed Xcode is too old and doesn't know about Swift 6 mode, so it fails with: SWIFT_VERSION '6' is unsupported, supported versions are: 4.0, 4.2, 5.0 (rdar://126952308) # Conflicts: # Package.swift
|
swiftlang/swift-package-manager#7500 @swift-ci Please test |
bnbarham
approved these changes
Apr 25, 2024
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 26, 2024
…ift 6 mode (#7500) Companion of swiftlang/swift-syntax#2627 - **Explanation**: This allows us to work around the following issue in CI: The self-hosted SwiftPM job has Xcode 15.3 (Swift 5.10) installed and builds a Swift 6 SwiftPM from source. It then tries to build itself as a fat binary using the just-built Swift 6 SwiftPM, which uses xcbuild from Xcode as the build system. But the xcbuild in the installed Xcode is too old and doesn't know about Swift 6 mode, so it fails with: SWIFT_VERSION '6' is unsupported, supported versions are: 4.0, 4.2, 5.0 (rdar://126952308). This is fixed by setting `SWIFTSYNTAX_DISABLE_SWIFT_6_MODE` in `build-using-self`. The source compat suite is seeing the same issue, just by using `bootstrap`, so set it there as well. - **Scope**: The build of SwiftPM using the `bootstrap` and `build-using-self` scripts - **Risk**: All issues that might have been caused by this will be found at build time - **Testing**: Verified that both the self hosted Swift CI job and the source compat suite build fine with #7495 - **Issue**: rdar://125579439 - **Reviewer**: @MaxDesiatov on #7495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.