Skip to content

Extract Codable conformance of RawSyntax into an extension #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 31, 2018

Extract the conformance of RawSyntax to Codable into an extension for clearer separation of concerns.

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #3 though.

@rintaro
Copy link
Member

rintaro commented Sep 11, 2018

@ahoppen
Copy link
Member Author

ahoppen commented Sep 12, 2018

@rintaro I know it's conflicting, I'll resolve the conflicts in #3 later. And thanks for triggering CI from the swift repo.

@ahoppen ahoppen merged commit 66388d3 into swiftlang:master Sep 12, 2018
@rintaro
Copy link
Member

rintaro commented Sep 12, 2018

@ahoppen Sorry, but please hold off from merging PRs until both @nkcsgexi and I approve them.
We'll finishing it by tomorrow.
(No need to revert)

@ahoppen ahoppen deleted the rawsyntax-codable-conformance-extension branch September 12, 2018 07:26
CippoX added a commit to CippoX/swift-syntax that referenced this pull request Mar 21, 2023
# This is the 1st commit message:

fixed testAvailabilityQuery34 and testAvailabilityQueryUnavailability28

# This is the commit message swiftlang#2:

Update Sources/SwiftParserDiagnostics/ParseDiagnosticsGenerator.swift

Co-authored-by: Kim de Vos <[email protected]>
# This is the commit message swiftlang#3:

added fixedSource in test case

# This is the commit message swiftlang#4:

minor changes

# This is the commit message swiftlang#5:

implemented recovery inside the parser

# This is the commit message swiftlang#6:

runned format.py

# This is the commit message swiftlang#7:

minor changes

# This is the commit message swiftlang#8:

minor changes
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Ensure a space after `case` in a `for case ... in` statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants