Fix RawSyntax's leading/trailingTrivia computation to return nil if the outermost children don't have leading/trailing trivia #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts outermost children don't have leading/trailing trivia Previously if would skip over outer children that didn't have leading/trailing trivia until it found one that did. This was causing that trivia to be included twice when computing the totalLength/byteSize of the node; once in leading/trailingTrivia and again in contentlength, which only skipped the trivia of the outmost children.
|
@swift-ci please test |
|
Good catch. Thanks. We should also cherry-pick this over to |
allevato
pushed a commit
to allevato/swift-syntax
that referenced
this pull request
Sep 17, 2018
…h-when-last-child-has-no-trailing-trivia Fix RawSyntax's leading/trailingTrivia computation to return nil if the outermost children don't have leading/trailing trivia
nkcsgexi
added a commit
that referenced
this pull request
Sep 17, 2018
[4.2] Merge pull request #8 from nathawes/fix-rawsyntax-totallength-when-la…
CippoX
added a commit
to CippoX/swift-syntax
that referenced
this pull request
Mar 21, 2023
# This is the 1st commit message: fixed testAvailabilityQuery34 and testAvailabilityQueryUnavailability28 # This is the commit message swiftlang#2: Update Sources/SwiftParserDiagnostics/ParseDiagnosticsGenerator.swift Co-authored-by: Kim de Vos <[email protected]> # This is the commit message swiftlang#3: added fixedSource in test case # This is the commit message swiftlang#4: minor changes # This is the commit message swiftlang#5: implemented recovery inside the parser # This is the commit message swiftlang#6: runned format.py # This is the commit message swiftlang#7: minor changes # This is the commit message swiftlang#8: minor changes
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Indent line comments correctly when they precede a continuation line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they would skip over outer children that didn't have leading/trailing trivia until they found one that did. This was causing those trivia to be included twice when computing the totalLength/byteSize of the node; once in leading/trailingTrivia and again in contentLength, which only skipped the trivia of the outermost children.