Adopt lexicalContext from swift-syntax-6.0.0.
#279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
commented
Mar 11, 2024
|
@swift-ci please test |
grynspan
changed the title
lexicalContext from swift-syntax-6.0.0.lexicalContext from swift-syntax-6.0.0.
grynspan
force-pushed
the
jgrynspan/109439578-lexical-context
branch
from
367a9a1 to
3f27a94
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
grynspan
changed the title
lexicalContext from swift-syntax-6.0.0.lexicalContext from swift-syntax-6.0.0.
grynspan
force-pushed
the
jgrynspan/109439578-lexical-context
branch
from
0fa73ce to
7d10292
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
Holding on to this PR for the moment as I'd like @DougGregor's review as well. |
DougGregor
approved these changes
Mar 21, 2024
grynspan
force-pushed
the
jgrynspan/109439578-lexical-context
branch
from
7d10292 to
7930fbf
Compare
This PR conditionally adopts the new `lexicalContext` member of `MacroExpansionContext` added in swiftlang/swift-syntax#1554. If the SwiftSyntax600 pseudo-module is available, then this member should be available for use and can be used to perform additional diagnostics for tests and to get the names of their containing types. With this PR, if built against an older toolchain (5.11 or earlier), the old hacky "is there leading whitespace?" mechanism is still used. A future PR will recursively perform suite-level diagnostics on the lexical contexts containing tests and suites, so that a test cannot be (easily) inserted into a type that cannot be used as a suite. Resolves rdar://109439578.
grynspan
force-pushed
the
jgrynspan/109439578-lexical-context
branch
from
7930fbf to
85ecedf
Compare
|
@swift-ci please test |
2 tasks
grynspan
added a commit
that referenced
this pull request
Apr 4, 2024
Follow-up to #279 and #302. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR conditionally adopts the new
lexicalContextmember ofMacroExpansionContextadded in swiftlang/swift-syntax#1554. If the SwiftSyntax600 pseudo-module is available, then this member should be available for use and can be used to perform additional diagnostics for tests and to get the names of their containing types.With this PR, if built against an older toolchain (5.11 or earlier), the old hacky "is there leading whitespace?" mechanism is still used.
A future PR will recursively perform suite-level diagnostics on the lexical contexts containing tests and suites, so that a test cannot be (easily) inserted into a type that cannot be used as a suite.
Resolves rdar://109439578.
Checklist: