Skip to content

[Serialization] Encode depth for cross-refs to generic parameters #20091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2018
Merged

[Serialization] Encode depth for cross-refs to generic parameters #20091

merged 2 commits into from
Nov 1, 2018

Conversation

jrose-apple
Copy link
Contributor

Otherwise, we can't represent a cross-reference to generic parameters in a parent type when used in an extension.

SR-9084 / rdar://problem/45566043

@jrose-apple
[test] Give xref-extensions.swift a name that discourages additions
191481f 
This file is very specifically counting the number of declarations
that get deserialized under a certain scenario, and so it's not really
the place to add tests for other things about cross-references and
extensions.
@jrose-apple
[Serialization] Encode depth for cross-refs to generic parameters
3455510 
Otherwise, we can't represent a cross-reference to generic parameters
in a parent type /when used in an extension/.

https://bugs.swift.org/browse/SR-9084
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Oct 26, 2018 •
edited
Loading

Oops, this…doesn't actually solve the problem yet. Please hold. Never mind, forgot to re-rebuild from my testing config.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test compiler performance

slavapestov
slavapestov approved these changes Oct 27, 2018
View reviewed changes
lib/Serialization/Deserialization.cpp
}
while (currentDepth > depth) {
paramList = paramList->getOuterParameters();
--currentDepth;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth asserting that the GenericTypeParamDecl you find below has the right depth and index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good idea for the AST verifier in general. It's set up by construction that the depth matches the GenericParamList's notion of depth, but the GenericParamList and the GenericTypeParamDecl could be out of sync. I'll do that in a follow-up PR.

@jrose-apple jrose-apple mentioned this pull request Oct 27, 2018
Merged
@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, excluded stats for RxSwift, NonEmpty, Wordy, GRDB, ReactiveSwift

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 14,909,764,424,282 15,195,011,628,401 285,247,204,119 1.91% ⛔
LLVM.NumLLVMBytesOutput 667,732,228 674,881,690 7,149,462 1.07% ⛔
time.swift-driver.wall 1725.4s 1749.0s 23.6s 1.37% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (0)
name old new delta delta_pct

debug-batch detailed

Regressed (50)
name old new delta delta_pct
AST.NumASTBytesAllocated 19,540,898,260 19,932,799,203 391,900,943 2.01% ⛔
AST.NumDecls 47,822 48,727 905 1.89% ⛔
AST.NumDependencies 131,838 135,916 4,078 3.09% ⛔
AST.NumImportedExternalDefinitions 890,528 922,173 31,645 3.55% ⛔
AST.NumLoadedModules 156,076 159,996 3,920 2.51% ⛔
AST.NumLocalTypeDecls 79 111 32 40.51% ⛔
AST.NumObjCMethods 12,197 12,322 125 1.02% ⛔
AST.NumPrecedenceGroups 9,162 9,348 186 2.03% ⛔
AST.NumReferencedDynamicNames 45 101 56 124.44% ⛔
AST.NumReferencedTopLevelNames 154,960 157,702 2,742 1.77% ⛔
AST.NumSourceBuffers 201,831 206,348 4,517 2.24% ⛔
AST.NumSourceLinesPerSecond 976,855 987,096 10,241 1.05% ⛔
AST.NumTotalClangImportedEntities 3,027,541 3,136,533 108,992 3.6% ⛔
AST.NumUsedConformances 145,845 147,644 1,799 1.23% ⛔
Driver.ChildrenMaxRSS 52,720,814,080 53,377,075,200 656,261,120 1.24% ⛔
Driver.NumDriverJobsRun 9,787 9,983 196 2.0% ⛔
Frontend.MaxMallocUsage 249,495,018,464 255,052,127,680 5,557,109,216 2.23% ⛔
Frontend.NumInstructionsExecuted 14,909,764,424,282 15,195,011,628,401 285,247,204,119 1.91% ⛔
IRModule.NumIRBasicBlocks 2,436,660 2,463,275 26,615 1.09% ⛔
IRModule.NumIRFunctions 1,231,285 1,246,979 15,694 1.27% ⛔
IRModule.NumIRGlobals 1,451,778 1,467,602 15,824 1.09% ⛔
IRModule.NumIRNamedMetaData 47,671 48,626 955 2.0% ⛔
IRModule.NumIRValueSymbols 2,388,857 2,418,468 29,611 1.24% ⛔
LLVM.NumLLVMBytesOutput 667,732,228 674,881,690 7,149,462 1.07% ⛔
Parse.NumFunctionsParsed 1,512,345 1,529,146 16,801 1.11% ⛔
Parse.NumIterableDeclContextParsed 537,254 545,726 8,472 1.58% ⛔
SILModule.NumSILGenGlobalVariables 24,802 25,207 405 1.63% ⛔
SILModule.NumSILGenVtables 4,609 4,662 53 1.15% ⛔
SILModule.NumSILOptGlobalVariables 25,465 25,870 405 1.59% ⛔
Sema.DefaultAndMaxAccessLevelRequest 31,351 31,737 386 1.23% ⛔
Sema.ExtendedNominalRequest 1,921,819 1,967,612 45,793 2.38% ⛔
Sema.InheritedDeclsReferencedRequest 63,233,718 64,418,068 1,184,350 1.87% ⛔
Sema.InheritedTypeRequest 355,841 361,165 5,324 1.5% ⛔
Sema.NamedLazyMemberLoadFailureCount 16,113 16,570 457 2.84% ⛔
Sema.NamedLazyMemberLoadSuccessCount 14,247,620 14,411,372 163,752 1.15% ⛔
Sema.NominalTypeLookupDirectCount 22,349,035 22,736,299 387,264 1.73% ⛔
Sema.NumConformancesDeserialized 1,980,813 2,013,887 33,074 1.67% ⛔
Sema.NumDeclsDeserialized 19,024,849 19,402,758 377,909 1.99% ⛔
Sema.NumFunctionsTypechecked 782,035 803,112 21,077 2.7% ⛔
Sema.NumGenericSignatureBuilders 654,402 672,216 17,814 2.72% ⛔
Sema.NumLazyGenericEnvironments 4,126,448 4,210,279 83,831 2.03% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 96,242 97,817 1,575 1.64% ⛔
Sema.NumLazyIterableDeclContexts 3,874,255 3,976,735 102,480 2.65% ⛔
Sema.NumTypesDeserialized 7,910,165 8,086,748 176,583 2.23% ⛔
Sema.NumUnloadedLazyIterableDeclContexts 3,118,132 3,203,744 85,612 2.75% ⛔
Sema.RequirementRequest 23,388 23,957 569 2.43% ⛔
Sema.SelfBoundsFromWhereClauseRequest 35,293,169 35,855,270 562,101 1.59% ⛔
Sema.SuperclassDeclRequest 52,417,794 53,402,150 984,356 1.88% ⛔
Sema.TypeDeclsFromWhereClauseRequest 14,607 14,962 355 2.43% ⛔
Sema.USRGenerationRequest 239,714 242,181 2,467 1.03% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (45)
name old new delta delta_pct
AST.NumInfixOperators 19,798 19,952 154 0.78%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumPostfixOperators 14 14 0 0.0%
AST.NumPrefixOperators 61 61 0 0.0%
AST.NumReferencedMemberNames 2,544,773 2,569,636 24,863 0.98%
AST.NumSourceLines 1,572,920 1,585,540 12,620 0.8%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 206,991 206,400 -591 -0.29%
Driver.NumDriverPipeReads 228,367 228,147 -220 -0.1%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 75,850 76,318 468 0.62%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 27,862,213 28,075,858 213,645 0.77%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,088,081 1,094,828 6,747 0.62%
SILModule.NumSILGenWitnessTables 28,286 28,511 225 0.8%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 932,434 940,427 7,993 0.86%
SILModule.NumSILOptVtables 8,819 8,898 79 0.9%
SILModule.NumSILOptWitnessTables 57,183 57,703 520 0.91%
Sema.AccessLevelRequest 1,327,731 1,336,198 8,467 0.64%
Sema.EnumRawTypeRequest 10,680 10,727 47 0.44%
Sema.IsDynamicRequest 1,202,628 1,213,073 10,445 0.87%
Sema.IsObjCRequest 1,006,851 1,013,496 6,645 0.66%
Sema.NumConstraintScopes 12,547,991 12,639,686 91,695 0.73%
Sema.NumConstraintsConsideredForEdgeContraction 19,403,560 19,460,488 56,928 0.29%
Sema.NumDeclsValidated 1,222,194 1,229,917 7,723 0.63%
Sema.NumLeafScopes 9,370,448 9,440,328 69,880 0.75%
Sema.NumTypesValidated 801,547 806,799 5,252 0.66%
Sema.OverriddenDeclsRequest 1,060,508 1,069,180 8,672 0.82%
Sema.SetterAccessLevelRequest 79,142 79,337 195 0.25%
Sema.SuperclassTypeRequest 17,779 17,952 173 0.97%
Sema.UnderlyingTypeDeclsReferencedRequest 1,801,212 1,813,883 12,671 0.7%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 93,558,836,117,497 18,335,482,479,971 -75,223,353,637,526 -80.4% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 566,135,956 566,137,048 1,092 0.0%
time.swift-driver.wall 3564.0s 3557.7s -6.3s -0.18%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 171,310 171,310 0 0.0%
AST.NumLoadedModules 10,578 10,578 0 0.0%
AST.NumTotalClangImportedEntities 573,121 573,121 0 0.0%
AST.NumUsedConformances 149,863 149,863 0 0.0%
IRModule.NumIRBasicBlocks 2,400,772 2,400,772 0 0.0%
IRModule.NumIRFunctions 995,788 995,788 0 0.0%
IRModule.NumIRGlobals 1,130,773 1,130,773 0 0.0%
IRModule.NumIRInsts 20,115,128 20,115,128 0 0.0%
IRModule.NumIRValueSymbols 1,962,027 1,962,027 0 0.0%
LLVM.NumLLVMBytesOutput 566,135,956 566,137,048 1,092 0.0%
SILModule.NumSILGenFunctions 448,709 448,709 0 0.0%
SILModule.NumSILOptFunctions 636,013 636,013 0 0.0%
Sema.NumConformancesDeserialized 1,293,746 1,293,746 0 0.0%
Sema.NumConstraintScopes 11,249,986 11,249,986 0 0.0%
Sema.NumDeclsDeserialized 3,898,329 3,898,329 0 0.0%
Sema.NumDeclsValidated 583,625 583,625 0 0.0%
Sema.NumFunctionsTypechecked 349,641 349,641 0 0.0%
Sema.NumGenericSignatureBuilders 126,758 126,758 0 0.0%
Sema.NumLazyGenericEnvironments 812,392 812,392 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 15,708 15,708 0 0.0%
Sema.NumLazyIterableDeclContexts 512,949 512,949 0 0.0%
Sema.NumTypesDeserialized 2,183,050 2,183,050 0 0.0%
Sema.NumTypesValidated 266,179 266,179 0 0.0%

@clackary clackary mentioned this pull request Oct 27, 2018
Merged
@jrose-apple
Copy link
Contributor Author

These compiler perf numbers are all wrong again. @graydon, worth investigating, or should I just move on?

@graydon
Copy link
Contributor

graydon commented Oct 30, 2018

@jrose-apple I've pushed a fix that ought to give better detection of failed modules. If you don't mind, I'd like to run the same cperf test again?

@graydon
Copy link
Contributor

graydon commented Oct 30, 2018

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, excluded stats for NonEmpty, RxSwift, Wordy, GRDB, ReactiveSwift

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 13,148,416,223,757 13,363,959,862,988 215,543,639,231 1.64% ⛔
LLVM.NumLLVMBytesOutput 682,887,656 690,037,348 7,149,692 1.05% ⛔
time.swift-driver.wall 1486.9s 1505.3s 18.4s 1.24% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (0)
name old new delta delta_pct

debug-batch detailed

Regressed (52)
name old new delta delta_pct
AST.NumASTBytesAllocated 15,803,646,140 16,111,467,975 307,821,835 1.95% ⛔
AST.NumDecls 48,146 49,051 905 1.88% ⛔
AST.NumDependencies 103,193 106,007 2,814 2.73% ⛔
AST.NumImportedExternalDefinitions 748,802 774,521 25,719 3.43% ⛔
AST.NumLoadedModules 124,150 126,887 2,737 2.2% ⛔
AST.NumLocalTypeDecls 79 111 32 40.51% ⛔
AST.NumObjCMethods 12,249 12,374 125 1.02% ⛔
AST.NumPrecedenceGroups 9,217 9,403 186 2.02% ⛔
AST.NumReferencedDynamicNames 44 100 56 127.27% ⛔
AST.NumReferencedTopLevelNames 154,345 157,054 2,709 1.76% ⛔
AST.NumSourceBuffers 142,971 146,066 3,095 2.16% ⛔
AST.NumSourceLinesPerSecond 1,086,771 1,100,160 13,389 1.23% ⛔
AST.NumTotalClangImportedEntities 2,584,032 2,671,752 87,720 3.39% ⛔
AST.NumUsedConformances 146,832 148,631 1,799 1.23% ⛔
Driver.ChildrenMaxRSS 51,999,553,536 52,735,438,848 735,885,312 1.42% ⛔
Driver.NumDriverJobsRun 9,852 10,048 196 1.99% ⛔
Driver.NumDriverPipePolls 263,265 269,844 6,579 2.5% ⛔
Driver.NumDriverPipeReads 277,349 284,776 7,427 2.68% ⛔
Frontend.MaxMallocUsage 206,379,576,040 210,380,008,856 4,000,432,816 1.94% ⛔
Frontend.NumInstructionsExecuted 13,148,416,223,757 13,363,959,862,988 215,543,639,231 1.64% ⛔
IRModule.NumIRBasicBlocks 2,472,436 2,499,051 26,615 1.08% ⛔
IRModule.NumIRFunctions 1,255,825 1,271,519 15,694 1.25% ⛔
IRModule.NumIRGlobals 1,505,594 1,521,418 15,824 1.05% ⛔
IRModule.NumIRNamedMetaData 47,991 48,946 955 1.99% ⛔
IRModule.NumIRValueSymbols 2,451,016 2,480,627 29,611 1.21% ⛔
LLVM.NumLLVMBytesOutput 682,887,656 690,037,348 7,149,692 1.05% ⛔
Parse.NumFunctionsParsed 1,064,347 1,075,845 11,498 1.08% ⛔
Parse.NumIterableDeclContextParsed 383,483 389,291 5,808 1.51% ⛔
SILModule.NumSILGenGlobalVariables 24,870 25,275 405 1.63% ⛔
SILModule.NumSILGenVtables 4,628 4,681 53 1.15% ⛔
SILModule.NumSILOptGlobalVariables 25,543 25,948 405 1.59% ⛔
Sema.DefaultAndMaxAccessLevelRequest 28,379 28,747 368 1.3% ⛔
Sema.ExtendedNominalRequest 1,595,733 1,631,904 36,171 2.27% ⛔
Sema.InheritedDeclsReferencedRequest 59,233,669 60,258,452 1,024,783 1.73% ⛔
Sema.InheritedTypeRequest 342,712 346,832 4,120 1.2% ⛔
Sema.NamedLazyMemberLoadFailureCount 14,109 14,488 379 2.69% ⛔
Sema.NamedLazyMemberLoadSuccessCount 13,393,285 13,541,587 148,302 1.11% ⛔
Sema.NominalTypeLookupDirectCount 20,878,312 21,216,068 337,756 1.62% ⛔
Sema.NumConformancesDeserialized 1,789,355 1,817,857 28,502 1.59% ⛔
Sema.NumDeclsDeserialized 16,485,297 16,801,138 315,841 1.92% ⛔
Sema.NumFunctionsTypechecked 699,258 716,987 17,729 2.54% ⛔
Sema.NumGenericSignatureBuilders 557,364 571,697 14,333 2.57% ⛔
Sema.NumLazyGenericEnvironments 3,557,214 3,626,426 69,212 1.95% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 92,101 93,621 1,520 1.65% ⛔
Sema.NumLazyIterableDeclContexts 3,210,151 3,289,431 79,280 2.47% ⛔
Sema.NumTypesDeserialized 6,800,935 6,944,312 143,377 2.11% ⛔
Sema.NumUnloadedLazyIterableDeclContexts 2,545,401 2,610,597 65,196 2.56% ⛔
Sema.RequirementRequest 22,055 22,604 549 2.49% ⛔
Sema.SelfBoundsFromWhereClauseRequest 32,928,947 33,411,404 482,457 1.47% ⛔
Sema.SuperclassDeclRequest 49,389,545 50,246,053 856,508 1.73% ⛔
Sema.TypeDeclsFromWhereClauseRequest 13,280 13,617 337 2.54% ⛔
Sema.USRGenerationRequest 241,476 243,943 2,467 1.02% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (43)
name old new delta delta_pct
AST.NumInfixOperators 19,949 20,103 154 0.77%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumPostfixOperators 14 14 0 0.0%
AST.NumPrefixOperators 61 61 0 0.0%
AST.NumReferencedMemberNames 2,563,526 2,588,389 24,863 0.97%
AST.NumSourceLines 1,586,277 1,598,897 12,620 0.8%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 76,199 76,667 468 0.61%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 28,293,203 28,506,848 213,645 0.76%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,203,740 1,210,487 6,747 0.56%
SILModule.NumSILGenWitnessTables 28,561 28,786 225 0.79%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 955,038 963,031 7,993 0.84%
SILModule.NumSILOptVtables 8,855 8,934 79 0.89%
SILModule.NumSILOptWitnessTables 57,777 58,297 520 0.9%
Sema.AccessLevelRequest 1,225,594 1,233,786 8,192 0.67%
Sema.EnumRawTypeRequest 9,233 9,280 47 0.51%
Sema.IsDynamicRequest 1,101,601 1,111,243 9,642 0.88%
Sema.IsObjCRequest 919,850 926,277 6,427 0.7%
Sema.NumConstraintScopes 12,321,143 12,404,222 83,079 0.67%
Sema.NumConstraintsConsideredForEdgeContraction 19,306,760 19,360,337 53,577 0.28%
Sema.NumDeclsValidated 1,135,085 1,142,745 7,660 0.67%
Sema.NumLeafScopes 9,185,865 9,248,826 62,961 0.69%
Sema.NumTypesValidated 730,050 735,131 5,081 0.7%
Sema.OverriddenDeclsRequest 967,395 975,538 8,143 0.84%
Sema.SetterAccessLevelRequest 72,965 73,158 193 0.26%
Sema.SuperclassTypeRequest 16,818 16,983 165 0.98%
Sema.UnderlyingTypeDeclsReferencedRequest 1,725,699 1,737,683 11,984 0.69%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 140,530,428,066,778 18,387,886,872,755 -122,142,541,194,023 -86.92% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 568,215,628 568,216,988 1,360 0.0%
time.swift-driver.wall 3171.5s 3170.8s -747.7ms -0.02%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 171,556 171,556 0 0.0%
AST.NumLoadedModules 10,578 10,578 0 0.0%
AST.NumTotalClangImportedEntities 573,343 573,343 0 0.0%
AST.NumUsedConformances 150,695 150,695 0 0.0%
IRModule.NumIRBasicBlocks 2,414,155 2,414,155 0 0.0%
IRModule.NumIRFunctions 999,830 999,830 0 0.0%
IRModule.NumIRGlobals 1,134,420 1,134,420 0 0.0%
IRModule.NumIRInsts 20,196,149 20,196,149 0 0.0%
IRModule.NumIRValueSymbols 1,969,282 1,969,282 0 0.0%
LLVM.NumLLVMBytesOutput 568,215,628 568,216,988 1,360 0.0%
SILModule.NumSILGenFunctions 451,201 451,201 0 0.0%
SILModule.NumSILOptFunctions 639,413 639,413 0 0.0%
Sema.NumConformancesDeserialized 1,301,597 1,301,597 0 0.0%
Sema.NumConstraintScopes 11,250,046 11,250,046 0 0.0%
Sema.NumDeclsDeserialized 3,907,224 3,907,224 0 0.0%
Sema.NumDeclsValidated 587,689 587,689 0 0.0%
Sema.NumFunctionsTypechecked 351,293 351,293 0 0.0%
Sema.NumGenericSignatureBuilders 127,206 127,206 0 0.0%
Sema.NumLazyGenericEnvironments 813,902 813,902 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 15,759 15,759 0 0.0%
Sema.NumLazyIterableDeclContexts 513,680 513,680 0 0.0%
Sema.NumTypesDeserialized 2,191,319 2,191,319 0 0.0%
Sema.NumTypesValidated 268,491 268,491 0 0.0%

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Oct 30, 2018 •
edited
Loading

Hm, not quite there yet…

Is the script only detecting when the new compiler fails? This is a change where it used to fail and now it succeeds.

@graydon
Copy link
Contributor

graydon commented Oct 30, 2018

@jrose-apple it's trying to figure out which modules failed in either instance (old or new) so it can exclude them from comparison. I .. do not understand what happened here. Sigh. Will try again.

@graydon
Copy link
Contributor

graydon commented Oct 30, 2018

@jrose-apple one more time!

@graydon
Copy link
Contributor

graydon commented Oct 30, 2018

@swift-ci Please test compiler performance

@shahmishal
Copy link
Member

@jrose-apple @graydon Going to have to kill compiler performance job, currently updating Xcode.

@swift-ci
Copy link
Contributor

Build comment file:

Compilation-performance test failed

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Nov 1, 2018

Build comment file:

Summary for master full

Unexpected test results, excluded stats for NonEmpty, ReactiveExtensions_TestHelpers, ProcedureKitCloud, GRDB, ReactiveSwift, ReactiveCocoa, Wordy, ReactiveExtensions

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 17,309,507,633,329 17,309,435,857,215 -71,776,114 -0.0%
LLVM.NumLLVMBytesOutput 845,647,800 845,640,346 -7,454 -0.0%
time.swift-driver.wall 1925.3s 1920.5s -4.8s -0.25%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (95)
name old new delta delta_pct
AST.NumASTBytesAllocated 22,988,667,669 22,988,566,994 -100,675 -0.0%
AST.NumDecls 61,300 61,300 0 0.0%
AST.NumDependencies 141,580 141,582 2 0.0%
AST.NumImportedExternalDefinitions 919,296 919,296 0 0.0%
AST.NumInfixOperators 23,732 23,732 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 169,235 169,235 0 0.0%
AST.NumLocalTypeDecls 81 81 0 0.0%
AST.NumObjCMethods 12,337 12,337 0 0.0%
AST.NumPostfixOperators 13 13 0 0.0%
AST.NumPrecedenceGroups 12,171 12,171 0 0.0%
AST.NumPrefixOperators 57 57 0 0.0%
AST.NumReferencedDynamicNames 46 46 0 0.0%
AST.NumReferencedMemberNames 2,992,189 2,992,179 -10 -0.0%
AST.NumReferencedTopLevelNames 200,455 200,455 0 0.0%
AST.NumSourceBuffers 276,775 276,775 0 0.0%
AST.NumSourceLines 1,954,754 1,954,736 -18 -0.0%
AST.NumSourceLinesPerSecond 1,149,361 1,157,113 7,752 0.67%
AST.NumTotalClangImportedEntities 3,209,955 3,209,955 0 0.0%
AST.NumUsedConformances 179,624 179,624 0 0.0%
Driver.ChildrenMaxRSS 56,301,826,048 56,220,205,056 -81,620,992 -0.14%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 12,986 12,986 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 296,682 298,654 1,972 0.66%
Driver.NumDriverPipeReads 335,118 337,696 2,578 0.77%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 282,768,171,688 282,568,800,584 -199,371,104 -0.07%
Frontend.NumInstructionsExecuted 17,309,507,633,329 17,309,435,857,215 -71,776,114 -0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 90,278 90,278 0 0.0%
IRModule.NumIRBasicBlocks 3,424,703 3,424,691 -12 -0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 1,536,175 1,536,167 -8 -0.0%
IRModule.NumIRGlobals 1,754,057 1,754,050 -7 -0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 35,599,927 35,599,381 -546 -0.0%
IRModule.NumIRNamedMetaData 63,546 63,546 0 0.0%
IRModule.NumIRValueSymbols 2,938,549 2,938,536 -13 -0.0%
LLVM.NumLLVMBytesOutput 845,647,800 845,640,346 -7,454 -0.0%
Parse.NumFunctionsParsed 1,980,904 1,980,856 -48 -0.0%
Parse.NumIterableDeclContextParsed 789,745 789,745 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,237,284 1,237,280 -4 -0.0%
SILModule.NumSILGenGlobalVariables 25,978 25,978 0 0.0%
SILModule.NumSILGenVtables 9,632 9,632 0 0.0%
SILModule.NumSILGenWitnessTables 35,980 35,980 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,128,932 1,128,926 -6 -0.0%
SILModule.NumSILOptGlobalVariables 26,711 26,711 0 0.0%
SILModule.NumSILOptVtables 15,499 15,499 0 0.0%
SILModule.NumSILOptWitnessTables 69,530 69,530 0 0.0%
Sema.AccessLevelRequest 1,697,161 1,697,142 -19 -0.0%
Sema.DefaultAndMaxAccessLevelRequest 41,642 41,642 0 0.0%
Sema.EnumRawTypeRequest 12,650 12,650 0 0.0%
Sema.ExtendedNominalRequest 2,222,880 2,222,880 0 0.0%
Sema.InheritedDeclsReferencedRequest 74,657,708 74,657,420 -288 -0.0%
Sema.InheritedTypeRequest 412,331 412,331 0 0.0%
Sema.IsDynamicRequest 1,448,196 1,448,184 -12 -0.0%
Sema.IsObjCRequest 1,216,131 1,216,120 -11 -0.0%
Sema.NamedLazyMemberLoadFailureCount 16,909 16,909 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 15,134,496 15,134,327 -169 -0.0%
Sema.NominalTypeLookupDirectCount 24,542,712 24,542,585 -127 -0.0%
Sema.NumConformancesDeserialized 2,257,485 2,257,485 0 0.0%
Sema.NumConstraintScopes 14,137,583 14,137,471 -112 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 23,786,488 23,785,982 -506 -0.0%
Sema.NumDeclsDeserialized 21,644,180 21,644,156 -24 -0.0%
Sema.NumDeclsValidated 1,499,647 1,499,631 -16 -0.0%
Sema.NumFunctionsTypechecked 878,653 878,650 -3 -0.0%
Sema.NumGenericSignatureBuilders 744,147 744,147 0 0.0%
Sema.NumLazyGenericEnvironments 4,758,630 4,758,620 -10 -0.0%
Sema.NumLazyGenericEnvironmentsLoaded 153,560 153,558 -2 -0.0%
Sema.NumLazyIterableDeclContexts 4,316,349 4,316,349 0 0.0%
Sema.NumLeafScopes 10,346,382 10,346,320 -62 -0.0%
Sema.NumTypesDeserialized 9,070,266 9,070,266 0 0.0%
Sema.NumTypesValidated 998,858 998,837 -21 -0.0%
Sema.NumUnloadedLazyIterableDeclContexts 3,464,728 3,464,728 0 0.0%
Sema.OverriddenDeclsRequest 1,271,652 1,271,641 -11 -0.0%
Sema.RequirementRequest 40,362 40,362 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 38,939,454 38,939,103 -351 -0.0%
Sema.SetterAccessLevelRequest 95,553 95,553 0 0.0%
Sema.SuperclassDeclRequest 62,880,873 62,880,650 -223 -0.0%
Sema.SuperclassTypeRequest 28,712 28,712 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 22,217 22,217 0 0.0%
Sema.USRGenerationRequest 306,384 306,377 -7 -0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 1,977,717 1,977,717 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 20,447,115,549,956 20,449,450,069,273 2,334,519,317 0.01%
LLVM.NumLLVMBytesOutput 687,188,188 687,186,200 -1,988 -0.0%
time.swift-driver.wall 3954.9s 3951.5s -3.4s -0.09%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 170,486 170,486 0 0.0%
AST.NumLoadedModules 10,892 10,892 0 0.0%
AST.NumTotalClangImportedEntities 579,304 579,304 0 0.0%
AST.NumUsedConformances 180,505 180,505 0 0.0%
IRModule.NumIRBasicBlocks 2,678,894 2,678,878 -16 -0.0%
IRModule.NumIRFunctions 1,221,303 1,221,296 -7 -0.0%
IRModule.NumIRGlobals 1,374,841 1,374,835 -6 -0.0%
IRModule.NumIRInsts 23,559,321 23,559,089 -232 -0.0%
IRModule.NumIRValueSymbols 2,392,384 2,392,372 -12 -0.0%
LLVM.NumLLVMBytesOutput 687,188,188 687,186,200 -1,988 -0.0%
SILModule.NumSILGenFunctions 533,604 533,600 -4 -0.0%
SILModule.NumSILOptFunctions 729,316 729,312 -4 -0.0%
Sema.NumConformancesDeserialized 1,360,789 1,360,789 0 0.0%
Sema.NumConstraintScopes 12,670,198 12,670,086 -112 -0.0%
Sema.NumDeclsDeserialized 4,055,529 4,055,525 -4 -0.0%
Sema.NumDeclsValidated 737,718 737,709 -9 -0.0%
Sema.NumFunctionsTypechecked 427,769 427,766 -3 -0.0%
Sema.NumGenericSignatureBuilders 143,478 143,478 0 0.0%
Sema.NumLazyGenericEnvironments 849,101 849,099 -2 -0.0%
Sema.NumLazyGenericEnvironmentsLoaded 16,673 16,673 0 0.0%
Sema.NumLazyIterableDeclContexts 529,929 529,929 0 0.0%
Sema.NumTypesDeserialized 2,279,152 2,279,152 0 0.0%
Sema.NumTypesValidated 361,103 361,096 -7 -0.0%

@jrose-apple
Copy link
Contributor Author

There we go! Merging.

@jrose-apple jrose-apple merged commit d60f2ff into swiftlang:master Nov 1, 2018
@jrose-apple jrose-apple deleted the deeply-cross branch November 1, 2018 15:59
@graydon
Copy link
Contributor

graydon commented Nov 2, 2018

@jrose-apple thanks for your perseverance, I know it's tedious and in a better world we'd have set all this up to be much more directly testable :(

@belkadan belkadan mentioned this pull request Oct 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrose-apple @swift-ci @graydon @shahmishal @slavapestov