Skip to content

Verify that a GenericTypeParamDecl's depth and index are correct #20100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

Verify that a GenericTypeParamDecl's depth and index are correct #20100

merged 1 commit into from
Nov 7, 2018

Conversation

jrose-apple
Copy link
Contributor

(with respect to the containing GenericParamList)

As suggested by @slavapestov in #20091.

jrose-apple
jrose-apple commented Oct 27, 2018
View reviewed changes
lib/AST/ASTVerifier.cpp Outdated
@@ -2715,6 +2715,37 @@ class Verifier : public ASTWalker {
verifyCheckedBase(nominal);
}

void verifyChecked(GenericTypeParamDecl *GTPD) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are any of these properties things we can meaningfully check in verifyParsed or verifyCheckedAlways (i.e. "verifyCheckedEvenIfThereAreErrorsAfterParsing")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slavapestov Question still relevant!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifyCheckedAlways() should be OK, but not verifyParsed() since the depth isn't set yet.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@slavapestov Review ping

@jrose-apple
Verify that a GenericTypeParamDecl's depth and index are correct
872d4c1 
(with respect to the containing GenericParamList)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 7, 2018

Build failed
Swift Test OS X Platform
Git Sha - 78c827c91a1e0b01d3c1c00446ab18ba2c1be6ee

@swift-ci
Copy link
Contributor

swift-ci commented Nov 7, 2018

Build failed
Swift Test Linux Platform
Git Sha - 78c827c91a1e0b01d3c1c00446ab18ba2c1be6ee

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test Linux

@jrose-apple jrose-apple merged commit 0bf65f1 into swiftlang:master Nov 7, 2018
@jrose-apple jrose-apple deleted the verify-on-thee branch November 7, 2018 19:22
@jrose-apple
Copy link
Contributor Author

Looks like this has problems in module merging. I'll get back to it soon, but reverting for now.

jrose-apple added a commit to jrose-apple/swift that referenced this pull request Nov 8, 2018
@jrose-apple
Revert "Verify that a GenericTypeParamDecl's depth and index are corr…
10b783c 
…ect"

This reverts swiftlang#20100 / commit 0bf65f1.
It's causing problems on the Source Compatibility bot.
@jrose-apple jrose-apple mentioned this pull request Nov 8, 2018
Merged
jrose-apple added a commit that referenced this pull request Nov 8, 2018
@jrose-apple
Revert "Verify that a GenericTypeParamDecl's depth and index are corr…
6a15b26 
…ect" (#20432)

This reverts #20100 / commit 0bf65f1.
It's causing problems on the Source Compatibility bot.
@jrose-apple jrose-apple mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrose-apple @swift-ci @slavapestov