Verify that a GenericTypeParamDecl's depth and index are correct #20445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Re-applied after fixing a bug in Serialization where the DeclContext wasn't being set correctly for extensions with nested parameters. I was unable to come up with a reduced test case, but the CoreStore project in the source compatibility suite was failing without the Serialization change, and now it isn't.
jrose-apple
force-pushed
the
verify-on-thee-once-more
branch
from
f69732a to
ffa73cb
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applying #20100, reverted in #20432, after fixing a bug in Serialization where the DeclContext wasn't being set correctly for extensions with nested parameters. I was unable to come up with a reduced test case, but the CoreStore project in the source compatibility suite was failing without the Serialization change, and now it isn't.