[TF] Use @rpath as install_name directory for standard library dylibs.
#31301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets "@rpath" as the directory in LC_DYLIB_ID for standard library dylibs. This is important for toolchains that provide custom standard library modules or that make changes to libswiftCore.dylib. This patch should not be upstreamed to master, where Swift-in-the-OS is king and it seems intended for Swift system libraries to be used.
|
With this patch, macOS toolchain builds ( The failure happens while building SwiftPM, on one macOS machine:
And while building SwiftSyntax, on another macOS machine:
|
|
Closing this failed attempt. If we revisit this, we'll need to fix the resultant SwiftPM build issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets
@rpathas the directory inLC_DYLIB_IDfor standard library dylibs.This is important for toolchains that provide custom standard library modules or
that make changes to
libswiftCore.dylib.This patch should not be upstreamed to master, where Swift-in-the-OS is king and
it seems intended for Swift system libraries to be used.
This patch was designed to fix
TensorFlowmodule usages on macOS (TF-1260):Fix verification is pending.
The
-DSWIFT_DARWIN_STDLIB_INSTALL_NAME_DIR:STRING="@rpath"configuration comes from compnerd/swift-build.