Skip to content

[build] NFC: document tensorflow branch CMake options. #31526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2020
Merged

[build] NFC: document tensorflow branch CMake options. #31526

merged 1 commit into from
May 4, 2020

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented May 4, 2020 •
edited
Loading

Document SWIFT_ENABLE_TENSORFLOW CMake option.
Explain that it affects the tensorflow lit testing available feature.

Factored out from #31301.

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label May 4, 2020
@dan-zheng dan-zheng requested a review from compnerd May 4, 2020 03:16
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

compnerd
compnerd reviewed May 4, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems fine, but I don't think that it really adds any value. The option should be documented in CMake if you want to add documentation.

@dan-zheng
[build] NFC: document tensorflow branch CMake options.
e28caf6 
Document `SWIFT_ENABLE_TENSORFLOW` CMake option. Explain that it affects the
"tensorflow" lit testing available feature.
@dan-zheng dan-zheng force-pushed the tensorflow-cmake-options branch from 0141911 to e28caf6 Compare May 4, 2020 05:07
@dan-zheng
Copy link
Contributor Author

The option should be documented in CMake if you want to add documentation.

Good point! I moved the documentation to the SWIFT_ENABLE_TENSORFLOW CMake flag.

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng dan-zheng merged commit 29ad3f5 into swiftlang:tensorflow May 4, 2020
@dan-zheng dan-zheng deleted the tensorflow-cmake-options branch May 4, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

Assignees
No one assigned
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-zheng @compnerd