Skip to content

[IRGen] swift_getFunctionTypeMetadataGlobalActor has concurrency availability #38140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2021
Merged

[IRGen] swift_getFunctionTypeMetadataGlobalActor has concurrency availability #38140

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d40fdb4
[IRGen] `swift_getFunctionTypeMetadataGlobalActor` has concurrency av…
DougGregor Jun 28, 2021
1ae79db
Fix linkage for references to async function pointers.
DougGregor Jun 28, 2021
6801eba
Re-enable now-passing test on Linux
DougGregor Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/swift/Runtime/RuntimeFunctions.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ FUNCTION(GetFunctionMetadataDifferentiable,
// const Metadata *globalActor);
FUNCTION(GetFunctionMetadataGlobalActor,
swift_getFunctionTypeMetadataGlobalActor,
C_CC, AlwaysAvailable,
C_CC, ConcurrencyAvailability,
RETURNS(TypeMetadataPtrTy),
ARGS(SizeTy,
SizeTy,
Expand Down
2 changes: 1 addition & 1 deletion lib/IRGen/Linking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ SILLinkage LinkEntity::getLinkage(ForDefinition_t forDefinition) const {
case Kind::DispatchThunkAllocatorAsyncFunctionPointer:
case Kind::PartialApplyForwarderAsyncFunctionPointer:
return getUnderlyingEntityForAsyncFunctionPointer()
.getLinkage(ForDefinition);
.getLinkage(forDefinition);
case Kind::KnownAsyncFunctionPointer:
return SILLinkage::PublicExternal;
case Kind::PartialApplyForwarder:
Expand Down
13 changes: 13 additions & 0 deletions test/IRGen/async/weak_availability.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// RUN: %target-swift-frontend -enable-implicit-dynamic -target %target-cpu-apple-macosx11 -Onone -emit-ir %s | %FileCheck --check-prefix=MAYBE-AVAILABLE %s
// REQUIRES: OS=macosx && CPU=x86_64

@available(macOS 12.0, *)
public func f<S: AsyncSequence>(_ s: S) async throws -> Any.Type {
for try await _ in s { }

typealias Fn = @MainActor () -> S.Element
return Fn.self
}

// MAYBE-AVAILABLE: @"$sScI4next7ElementQzSgyYaKFTjTu" = extern_weak global
// MAYBE-AVAILABLE: declare{{.*}} extern_weak{{.*}} @swift_getFunctionTypeMetadataGlobalActor