[IRGen] swift_getFunctionTypeMetadataGlobalActor has concurrency availability
#38140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailability Fixes rdar://79674106.
|
@swift-ci please smoke test and merge |
We were not making references to async function pointers "weak" when the function itself was weak, because we were always calculating linkage as-if we were defining the async function pointer. Fixes the rest of rdar://79674106.
|
@swift-ci please smoke test and merge |
aschwaighofer
approved these changes
Jun 28, 2021
|
I don't understand why this succeeded now on Linux: |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Jul 17, 2021
Also see swiftlang#38140; we can remove this XFAIL just like Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two problems in IRGen where we were not correctly weak-importing them:
swift_getFunctionTypeMetadataGlobalActorwas not marked as having concurrency availabilityFixes rdar://79674106.