[IRGen] swift_getFunctionTypeMetadataGlobalActor has concurrency availability #38143
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailability Fixes rdar://79674106.
We were not making references to async function pointers "weak" when the function itself was weak, because we were always calculating linkage as-if we were defining the async function pointer. Fixes the rest of rdar://79674106.
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
@swift-ci please test |
DougGregor
deleted the
concurrency-availability-function-type-metadata-5.5
branch
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix two problems in IRGen where we were not correctly weak-importing symbols from the
_Concurrencylibrary, which caused crashes when the program was executed on OS's that do not include support for concurrency.Scope: Affects back-deployed applications that have adopted concurrency behind
@available(...).Radar/SR Issue: rdar://79674106
Risk: Low.
Testing: PR testing and CI on main.
Original PR: #38140