[ConstraintSystem] Adjust expression complexity computation to account for multi-statement closures #41282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each conjunction step should be executed in isolation from outer constraint system state, which should also include scope counter because otherwise, e.g. for large closures, solver might stop prematurely since all of the previous statements/expressions would contribute to the scope total.
Instead of asking callers of `isExpired` to provide the threshold, let's ask for that upfront. This change also allows us to check how much time remains in the timer and build timers with different thresholds without having to safe that information somewhere else.
…ing time until threshold
Original timer cannot be used each expression in the multi-statement closure is type-checked independently.
|
@swift-ci please test |
hborla
approved these changes
Feb 9, 2022
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each conjunction element should get their own number of scopes and time slice,
otherwise the larger the closure the sooner constraint solver would trigger
'too complex' incorrectly.