[ConstraintSystem] Improve precision of "too complex" diagnostic #58400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solver can now handle multiple different targets e.g. multi-statement closures, result builders etc. So it's more appropriate to say that the constraint system is too complex.
This would help to diagnose the initial point where constraint system has been determine to be "too complex"
hborla
approved these changes
Apr 27, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #41282 which introduced a
timer per sub-target. This patch takes advantage of the fact that
ExpressionTimeholds locator and uses that to compute affected range, which helps to point to a
particular sub-target were "too complex" has been detected.