ClangImporter: add support for Android API Notes #74829
Conversation
Introduce the first APINotes injection for the Android platform. This follows the VCRuntime pattern of permitting the SDK to provide API Notes that augment the system SDK. This adds a workaround for incorrect nullability on the `fts_open` function in bionic. The system library itself is fixed at: https://android-review.googlesource.com/c/platform/bionic/+/3151616
compnerd
requested review from
a team,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Oh nice, does this mean we can avoid the workarounds in our swift-corelibs-foundation pulls now? I will try this natively on Android and see. |
|
Depending on the workaround needed, yes. We should be able to fix any of the signatures but cannot fix the implementation of the library or add new functions without shims. |
|
@swift-ci please test |
I was talking about my workaround for this very Bionic I will try this pull out and see, but presumably the goal is to no longer require those changes. |
|
Yes, I think that we should be able to remove that workaround with this change. |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
|
||
| swift_install_in_component(FILES | ||
| posix_filesystem.apinotes | ||
| DESTINATION "share" |
There was a problem hiding this comment.
Do you install the compiler and this file on Windows before building swift-corelibs-foundation with that new installed location? I just tried using this with #5010 on Android and this file wasn't available, because build-script uses the freshly-built compiler in build/ to compile swift-corelibs-foundation, not the installed one from --install-prefix.
I will submit a change to place this file in build/ also, so we can use it when cross-compiling the corelibs for Android with build-script also.
There was a problem hiding this comment.
Yes, we install the compiler first to use it for the subsequent steps. I think that it makes more sense to change build-script to alter the behaviour and to stage the compiler first.
Introduce the first APINotes injection for the Android platform. This follows the VCRuntime pattern of permitting the SDK to provide API Notes that augment the system SDK. This adds a workaround for incorrect nullability on the
fts_openfunction in bionic. The system library itself is fixed at:https://android-review.googlesource.com/c/platform/bionic/+/3151616