[android] fix path and cmake local build target tracking for posix_fi… #75494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lesystem.apinotes This apinote file needs to be accessible in the locally built Android SDK as it's being built with build.ps1, so that swift-foundation can be built with that file present. This change ensures that the file is copied over into the local build directory for that Android SDK, in addition to being included in the installed component This change also places the component into lib/swift/apinotes, as that's where the clang importer already looks for API notes
hyp
requested review from
a team,
zoecarver,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
CC @finagolfin thanks for the pointer on the swift-foundation PR, this was the issue that prevented me from picking up posix_filesystem.apinotes |
|
@swift-ci please test |
finagolfin
approved these changes
Jul 26, 2024
|
Btw, I'm testing out the new LTS NDK 27 with the new Android overlay in Swift 6, and it's broken. No problem building the current Swift 5.10.1 and its old overlay with this new NDK though. |
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
|
@swift-ci please test windows |
|
@swift-ci please test Windows platform |
compnerd
approved these changes
Jul 26, 2024
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lesystem.apinotes
This apinote file needs to be accessible in the locally built Android SDK as it's being built with build.ps1, so that swift-foundation can be built with that file present. This change ensures that the file is copied over into the local build directory for that Android SDK, in addition to being included in the installed component
This change also places the component into lib/swift/apinotes, as that's where the clang importer already looks for API notes