-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Updates image to resolve #75109 #75161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The name of the swift repository has changed from apple/swift to swiftlang/swift
Update Repository name in GettingStarted.md
Why’d you close it? |
I had only uploaded the screenshot and hadn't updated the Howto guide of Pull Requests so I made all the changes and created a new pull request. Hope that's alright. This was my first time contributing to a huge codebase so was a little confused whether to submit changes one by one or all together |
All good. I thought maybe you had this common misconception that you cannot rewrite or add commits in a pull request. |
Oh I didn't know that. When I clicked on edit I could only change the name and other details so I just redid the whole thing. |
I see 🙂. A pull request wraps a branch, so whatever is done to that branch is reflected in the pull request. Nothing about the pull request itself, like its title, description, base branch, labels, etc., will affect the branch or changes — the former are independent GitHub-specific data. |
Ahh,got it. Thank you. I had sent another pull request solving all the issues, I wonder if you could look into it and review. :) |
Superseded by #75163. |
Uploading new screenshot for the "HowToGuide for First Pull" after the repository name was changed from apple/swift to swiftlang/swift .