Skip to content

Updates image to resolve #75109 #75161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Updates image to resolve #75109 #75161

wants to merge 4 commits into from

Conversation

vidhupv
Copy link
Contributor

@vidhupv vidhupv commented Jul 11, 2024

Uploading new screenshot for the "HowToGuide for First Pull" after the repository name was changed from apple/swift to swiftlang/swift .

vidhupv added 4 commits July 10, 2024 21:22
The name of the swift repository has changed from apple/swift to swiftlang/swift
Update Repository name in GettingStarted.md
@AnthonyLatsis
Copy link
Collaborator

Why’d you close it?

@vidhupv
Copy link
Contributor Author

vidhupv commented Jul 11, 2024

I had only uploaded the screenshot and hadn't updated the Howto guide of Pull Requests so I made all the changes and created a new pull request. Hope that's alright. This was my first time contributing to a huge codebase so was a little confused whether to submit changes one by one or all together

@AnthonyLatsis
Copy link
Collaborator

All good. I thought maybe you had this common misconception that you cannot rewrite or add commits in a pull request.

@vidhupv
Copy link
Contributor Author

vidhupv commented Jul 11, 2024

Oh I didn't know that. When I clicked on edit I could only change the name and other details so I just redid the whole thing.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Jul 11, 2024

I see 🙂. A pull request wraps a branch, so whatever is done to that branch is reflected in the pull request. Nothing about the pull request itself, like its title, description, base branch, labels, etc., will affect the branch or changes — the former are independent GitHub-specific data.

@vidhupv
Copy link
Contributor Author

vidhupv commented Jul 11, 2024

Ahh,got it. Thank you. I had sent another pull request solving all the issues, I wonder if you could look into it and review. :)

@AnthonyLatsis
Copy link
Collaborator

Superseded by #75163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants