-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Resolves #75109 #75163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #75109 #75163
Conversation
Update Repository name in GettingStarted.md
Uploading new screenshot to swiftlang/swift/docs to resolve swiftlang#75109 next.
Add files via upload to docs in order to resolve swiftlang#75109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Please take the screenshot directly from https://github.com/swiftlang/swift, which is where the doc suggests us to navigate. You could even crop it somewhat like this without the org name that brought about this issue:
-
The rest of our screenshots are in light mode. Let’s be consistent about that.
-
Mind tidying up the commit history and giving this pull request a proper title?
@AnthonyLatsis I shall do that. Just a couple of questions:
|
|
Could you try tidying up your commit history by squashing your commits via an interactive rebase rather than spawning new PRs? Let me know if you need help with that. You will definitely benefit from this skill if you are planning to contribute more. Also, we prefer rebasing on main over merging with main when resolving conflicts — these intermediary merge commits pollute the commit history for no good reason. |
Hey, I would greatly appreciate any help on that. I am just learning to use the rebase editor on my terminal. I have dropped a few previous redundant commits and am in the process of squashing the valid ones right now. |
Sure, feel free to reach out if you get stuck with anything specific. |
Superseded by #75220. |
New commits include uploading the new screenshot to docs under the name SwiftGithubCreatePRScreenshot.png and also changing the name of the screenshot location in the HowTo Guide for "First Pull Requests"