Skip to content

Updates screenshot for HowtoGuides of First PR #75220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates screenshot for HowtoGuides of First PR #75220

wants to merge 1 commit into from

Conversation

vidhupv
Copy link
Contributor

@vidhupv vidhupv commented Jul 12, 2024

Resolves #75109 .

@vidhupv vidhupv changed the title Updates screenshot for HowtoGuides for First PR Updates screenshot for HowtoGuides of First PR Jul 12, 2024
@AnthonyLatsis
Copy link
Collaborator

Ok, let’s go with this PR then.

AnthonyLatsis
AnthonyLatsis reviewed Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost the screenshot along the way?

@AnthonyLatsis AnthonyLatsis mentioned this pull request Jul 13, 2024
Closed
xedin
xedin requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the screenshot and re-request the review so this doesn't get lost.

@vidhupv
Copy link
Contributor Author

vidhupv commented Jul 18, 2024 •
edited
Loading

Hi @AnthonyLatsis @xedin , I thought the screenshot was added. Will do so soon.

@AnthonyLatsis
Copy link
Collaborator

@vidhupv Need help?

@AnthonyLatsis
Copy link
Collaborator

@vidhupv Could you crop the screenshot so that:

  • The left & right margins match.
  • The orange segment next to the top left corner is not visible?

Also, please consider rewording the commit title to be more specific. For example: Update screenshot in FirstPullRequest.md.

git commit --amend to squash staged changes into the last commit and edit its message, then force push.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Dec 24, 2024 •
edited
Loading

@vidhupv Are you still working on this?

@vidhupv
Copy link
Contributor Author

vidhupv commented Dec 24, 2024

@AnthonyLatsis Hi, yes. Sorry I was busy with some stuff and was planning to do over the break. Will get on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLatsis AnthonyLatsis AnthonyLatsis left review comments

@xedin xedin xedin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace old screenshot with new one in HowToGuide for First Pull
3 participants
@vidhupv @AnthonyLatsis @xedin