-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Create devcontainer.json #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create devcontainer.json #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic!
Why we should merge this?
- This is the fastest way to run the demo
- This is the easiest way to setup a development environment
- Easier for contributors to test their PRs.
- We are on GitHub and this is a great feature of GitHub
You should add a note under the platform.sh link in the readme.
Also, we can try to promote Symfony by having a Symfony template on https://github.com/codespaces/templates
Thanks @shyim for this contribution ... and thanks Jérôme for showing the importance of this. |
{ | ||
"image": "mcr.microsoft.com/devcontainers/base:ubuntu", | ||
"features": { | ||
"ghcr.io/shyim/devcontainers-features/symfony-cli:0": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the Symfony organisation host these images, so that it doesn't depend on an external contributor? (no offence to shyim, but this account may be closed, hacked, etc. and people would end up with no image or a counterfeit image).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if Symfony wants to host some stuff. I am open :)
You should also be pinning to a specific sha if you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz Would it be possible to add a project to the Symfony organisation in order to build some Docker images? Where (what repo) should we request this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Symfony CLI, this should probably be discussed on https://github.com/symfony-cli/symfony-cli/issues (and then, the repo needed for that would also live in that organization, not in the Symfony one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like I was confused by the ghcr.io
name, ghcr.io/shyim/devcontainers-features/symfony-cli:0
is not a Docker image as I expected but it's a text recipe. But it would be nice to host it on Symfony's side though, I'll open an issue.
Adds an example how to setup it on GitHub Codespaces