Skip to content

Create devcontainer.json#1369

Merged
javiereguiluz merged 1 commit into
symfony:mainfrom
shyim:main
Nov 14, 2022
Merged

Create devcontainer.json#1369
javiereguiluz merged 1 commit into
symfony:mainfrom
shyim:main

Conversation

@shyim
Copy link
Copy Markdown
Contributor

@shyim shyim commented Nov 13, 2022

Adds an example how to setup it on GitHub Codespaces

Copy link
Copy Markdown
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

Why we should merge this?

  • This is the fastest way to run the demo
  • This is the easiest way to setup a development environment
  • Easier for contributors to test their PRs.
  • We are on GitHub and this is a great feature of GitHub

You should add a note under the platform.sh link in the readme.

Also, we can try to promote Symfony by having a Symfony template on https://github.com/codespaces/templates

@javiereguiluz
Copy link
Copy Markdown
Member

Thanks @shyim for this contribution ... and thanks Jérôme for showing the importance of this.

@javiereguiluz javiereguiluz merged commit 2767915 into symfony:main Nov 14, 2022
{
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/shyim/devcontainers-features/symfony-cli:0": {},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the Symfony organisation host these images, so that it doesn't depend on an external contributor? (no offence to shyim, but this account may be closed, hacked, etc. and people would end up with no image or a counterfeit image).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if Symfony wants to host some stuff. I am open :)
You should also be pinning to a specific sha if you prefer

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz Would it be possible to add a project to the Symfony organisation in order to build some Docker images? Where (what repo) should we request this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Symfony CLI, this should probably be discussed on https://github.com/symfony-cli/symfony-cli/issues (and then, the repo needed for that would also live in that organization, not in the Symfony one)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like I was confused by the ghcr.io name, ghcr.io/shyim/devcontainers-features/symfony-cli:0 is not a Docker image as I expected but it's a text recipe. But it would be nice to host it on Symfony's side though, I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants