Skip to content

Create devcontainer.json #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Create devcontainer.json #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/shyim/devcontainers-features/symfony-cli:0": {},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the Symfony organisation host these images, so that it doesn't depend on an external contributor? (no offence to shyim, but this account may be closed, hacked, etc. and people would end up with no image or a counterfeit image).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if Symfony wants to host some stuff. I am open :)
You should also be pinning to a specific sha if you prefer

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz Would it be possible to add a project to the Symfony organisation in order to build some Docker images? Where (what repo) should we request this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Symfony CLI, this should probably be discussed on https://github.com/symfony-cli/symfony-cli/issues (and then, the repo needed for that would also live in that organization, not in the Symfony one)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like I was confused by the ghcr.io name, ghcr.io/shyim/devcontainers-features/symfony-cli:0 is not a Docker image as I expected but it's a text recipe. But it would be nice to host it on Symfony's side though, I'll open an issue.

"ghcr.io/shyim/devcontainers-features/php:0": {
"version": "8.1"
},
"ghcr.io/devcontainers/features/node:1": {
"version": "lts"
}
},
"updateContentCommand": {
"composer install": ["composer", "install"],
"yarn": ["yarn"]
},
"postAttachCommand": {
"server": "symfony server:start",
"yarn": ["yarn", "watch"]
}
}