Fix PSR4 in composer.json, add dump() #490
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,15 @@ | |
| "type": "project", | ||
| "description": "Symfony Demo Application", | ||
| "autoload": { | ||
| "psr-4": { | ||
| "AppBundle\\": "src/AppBundle/", | ||
| "CodeExplorerBundle\\": "src/CodeExplorerBundle/" | ||
| }, | ||
| "classmap": [ "app/AppKernel.php", "app/AppCache.php" ] | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { "Tests\\": "tests/" }, | ||
| "files": [ "vendor/symfony/symfony/src/Symfony/Component/VarDumper/Resources/functions/dump.php" ] | ||
|
There was a problem hiding this comment. why is this needed? isn't it supposed to already be included from the VarDumper There was a problem hiding this comment. This is more as to ask for clarifications. I seem to be unable to use the There was a problem hiding this comment. When symfony/symfony is required, the dump function is not autoloaded. It is only when symfony/var-dumper directly is. There was a problem hiding this comment. Isn't the There was a problem hiding this comment. @Pierstoval no, it is loaded when the DebugBundle is booted. but when running tests, it is common for it not to be booted, making it painful. This is why we added it as a dev autoloading here for convenience. There was a problem hiding this comment. Then symfony/symfony-standard#1025 should also be merged, shouldn't it? :) |
||
| }, | ||
| "require": { | ||
| "php" : ">=5.5.9", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whilst this may boost performance, it may be harder for new users don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But only if you create a ton of bundles in your app ... which by the way is now considered a bad practice in most of the cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well to be honest I don't even see why you need any bundle here in the first place, but it's not limited to bundles. It highly depends on how you manage your
srcbundle. I would personally promote more something like having aAppnamespace for the wholesrc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theofidry the symfony-demo project has a AppBundle namespace for its source, because this is what the Symfony best practices are telling (and the demo is also about showing these best practices).
The extra CodeExplorerBundle is more a project-specific vendor bundle actually (we haven't shared it as a real vendor bundle, because this feature simply does not make sense outside the demo project).
and enw users won't find it harder, as they won't need to change the autoload config of symfony-demo.