Correcting sf4 config path #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/packages/dev/swiftmailer.yaml
Outdated
| #swiftmailer: | ||
| #delivery_address: [email protected] | ||
| swiftmailer: | ||
| disable_delivery: true |
There was a problem hiding this comment.
I'm not sure about this change because in this app we try to be in sync as much as possible with the Symfony recipes. This option is used in the test config (https://github.com/symfony/recipes/blob/master/symfony/swiftmailer-bundle/2.5/config/packages/test/swiftmailer.yaml) but not in the dev config (https://github.com/symfony/recipes/blob/master/symfony/swiftmailer-bundle/2.5/config/packages/dev/swiftmailer.yaml).
javiereguiluz
approved these changes
Jan 10, 2018
|
Thank you @mstrom. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 10, 2018
This PR was merged into the master branch. Discussion ---------- Correcting sf4 config path Commits ------- 6db8ba9 Update the SwiftMailer dev config to match recipe a86bda3 Removing requirement to register twig extension in services.yaml 9c8ed6d Fixing swiftmailer config path and added missing config for dev env e4bdc3d Fixing path in Entity/Post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.