Skip to content

Correcting sf4 config path #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2018
Merged

Correcting sf4 config path #747

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4bdc3d
Fixing path in Entity/Post
mstrom Jan 7, 2018
9c8ed6d
Fixing swiftmailer config path and added missing config for dev env
mstrom Jan 7, 2018
a86bda3
Removing requirement to register twig extension in services.yaml
mstrom Jan 7, 2018
6db8ba9
Update the SwiftMailer dev config to match recipe
javiereguiluz Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/packages/dev/swiftmailer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#swiftmailer:
#delivery_address: [email protected]
swiftmailer:
disable_delivery: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change because in this app we try to be in sync as much as possible with the Symfony recipes. This option is used in the test config (https://github.com/symfony/recipes/blob/master/symfony/swiftmailer-bundle/2.5/config/packages/test/swiftmailer.yaml) but not in the dev config (https://github.com/symfony/recipes/blob/master/symfony/swiftmailer-bundle/2.5/config/packages/dev/swiftmailer.yaml).

2 changes: 1 addition & 1 deletion src/Entity/Post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class Post
{
/**
* Use constants to define configuration options that rarely change instead
* of specifying them in app/config/config.yml.
* of specifying them under parameters section in config/services.yaml file.
*
* See https://symfony.com/doc/current/best_practices/configuration.html#constants-vs-configuration-options
*/
Expand Down
2 changes: 1 addition & 1 deletion src/EventSubscriber/CommentNotificationSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function onCommentCreated(GenericEvent $event): void
->setBody($body, 'text/html')
;

// In app/config/config_dev.yml the 'disable_delivery' option is set to 'true'.
// In config/packages/dev/swiftmailer.yaml the 'disable_delivery' option is set to 'true'.
// That's why in the development environment you won't actually receive any email.
// However, you can inspect the contents of those unsent emails using the debug toolbar.
// See https://symfony.com/doc/current/email/dev_environment.html#viewing-from-the-web-debug-toolbar
Expand Down
3 changes: 0 additions & 3 deletions src/Twig/AppExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
*
* See https://symfony.com/doc/current/cookbook/templating/twig_extension.html
*
* In addition to creating the Twig extension class, before using it you must also
* register it as a service. See app/config/services.yml file for details.
*
* @author Ryan Weaver <[email protected]>
* @author Javier Eguiluz <[email protected]>
* @author Julien ITARD <[email protected]>
Expand Down