Use @IsGranted instead of @Security. #797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
May 10, 2018
| */ | ||
| public function edit(Request $request, Post $post): Response | ||
| { | ||
| $this->denyAccessUnlessGranted('edit', $post, 'Posts can only be edited by their authors.'); |
There was a problem hiding this comment.
It would be good to keep this as another way of doing the same but without the annotation one.
There was a problem hiding this comment.
I let an example in the show action (see the code)
|
Thanks @DevMDamien for this contribution! And congrats on your first contribution to the Symfony project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in issue #792, I replaced some
@Security("is_granted()")annotations by@IsGranted.