Skip to content

Flex uses unpacking by default #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrew-demb opened this issue Jan 10, 2021 · 3 comments
Closed

Flex uses unpacking by default #14814

andrew-demb opened this issue Jan 10, 2021 · 3 comments

Comments

@andrew-demb
Copy link
Contributor

Since symfony/flex#656 unpacking is enabled by default.
To use previous behavior user need explicitly use "--no-unpack".

Reference in doc: https://symfony.com/doc/4.4/setup.html#installing-packages (cannot provide persistent link to line in https://github.com/symfony/symfony-docs/blob/4.4/setup.rst)
@xabbuh
Copy link
Member

xabbuh commented Jan 11, 2021

@andrew-demb Thanks for noticing. Would you like to send a PR to change this?

@andrew-demb
Copy link
Contributor Author

No, I can't choose an appropriate alternative description due to lack of language knowledge :(

@wouterj
Copy link
Member

wouterj commented Jan 11, 2021

I would change the whole paragraph to something like:

You won't see the symfony/debug-pack dependency in your composer.json, as Flex automatically unpacks the pack. This means that it only adds the real packages as dependencies (e.g. you will see the new symfony/var-dumper in require-dev). While it is not recommended, you can use the composer require --no-unpack ... option to disable unpacking.

Please create a PR - this way we can give credits to you :) We're all non-native english speakers as well, so together we can make something readable 😉

@andrew-demb andrew-demb mentioned this issue Jan 11, 2021
Merged
javiereguiluz added a commit that referenced this issue Jan 11, 2021
@javiereguiluz
minor #14818 Fixes #14814 Default behavior about unpacking packs by F…
6630eef 
…lex changed (andrew-demb)

This PR was merged into the 4.4 branch.

Discussion
----------

Fixes #14814 Default behavior about unpacking packs by Flex changed

`symfony/flex` since `1.9.0` unpack packs by default (PR symfony/flex#656)

Text proposed by @wouterj (thank you!) in comment #14814 (comment)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `5.x` for features of unreleased versions).

-->

Commits
-------

5e74358 Fixes #14814 Default behavior about unpacking packs by Flex changed
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 11, 2021
@javiereguiluz
Merge branch '4.4' into 5.1
8f90add 
* 4.4:
  Fixes symfony#14814 Default behavior about unpacking packs by Flex changed
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 11, 2021
@javiereguiluz
Merge branch '5.1' into 5.2
b98e38a 
* 5.1:
  Fixes symfony#14814 Default behavior about unpacking packs by Flex changed
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 11, 2021
@javiereguiluz
Merge branch '5.2' into 5.x
bab3326 
* 5.2:
  Fixes symfony#14814 Default behavior about unpacking packs by Flex changed
This was referenced Oct 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/ci OskarStark/symfony-docs
fix/ci 2 symfony/symfony-docs
3 participants
@wouterj @xabbuh @andrew-demb