fix/ci #3
Closed
fix/ci #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great
…1989) This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Console] Update questionhelper.rst hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bf9e245 Update questionhelper.rst
… (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [Doctrine] Deprecate the reverse engineering docs Fixes symfony#16903. Commits ------- 9ed3b06 [Doctrine] Deprecate the reverse engineering docs
update sdn sensitive annotation.
… (alexislefebvre) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Releases: add details to minor and major versions <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 4ae363a Releases: add details to minor and major versions
…bridge.rst (mohamedGasmii) This PR was merged into the 4.4 branch. Discussion ---------- [PHPUnitBridge] [Automated Tests] Update phpunit_bridge.rst update dns sensitive annotation. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 8b85a3d [Automated Tests] Update phpunit_bridge.rst
…component documentation (alexandre-daubois) This PR was merged into the 4.4 branch. Discussion ---------- Fix ordered lists in secrets management and Form component documentation Commits ------- 6570ade Fix ordered lists in secrets management and Form component documentation
Adjust variable name to be like the definition in VoterInterface
This PR was merged into the 4.4 branch. Discussion ---------- [Security] Adjust variable name Adjust variable name to be like the definition in VoterInterface Commits ------- 12c1059 Adjust variable name
This PR was merged into the 4.4 branch. Discussion ---------- Use --webapp flag instead of --full <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- d68d7ee Use --webapp flag instead of --full
Fixing display php code block
This PR was merged into the 4.4 branch. Discussion ---------- [Security] Update security.rst Fixing display php code block <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 0b546b1 [Security] Update security.rst
… cookie docs (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] [HttpCache] Update a link to Varnish cookie docs Fixes symfony#16180. Commits ------- 0960134 [HttpCache] Update a link to Varnish cookie docs
…age (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- Improve the explanation of the setfacl command usage Fixes symfony#16708. Commits ------- 9600a87 Improve the explanation of the setfacl command usage
…viereguiluz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Security] Document the delete_cookies option Fixes symfony#16205 Please, someone help me review the XML config because it's probably wrong. Thanks! Commits ------- 91a9223 [Security] Document the delete_cookies option
…ons (javiereguiluz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Improve the description of command options Fixes symfony#16648. Commits ------- 14e501f [Console] Improve the description of command options
time function returns an int, while DateTime::createFromFormat requires a string!
This PR was submitted for the 6.1 branch but it was merged into the 4.4 branch instead. Discussion ---------- Correct time type return time function returns an int, while DateTime::createFromFormat requires a string! <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 43e7043 Correct time type return
…n that service definitions replace previous ones (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] [DependencyInjecion] Mention that service definitions replace previous ones Replaces symfony#16888 to add the warning message in the main article about services config. Commits ------- c9f83a4 [DependencyInjecion] Mention that service definitions replace previous ones
…r via php.ini directly (alexander-schranz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Session] Add docs to define redis session handler via php.ini directly I think the most easiest way to configure session handling via redis is still configure it via `php.ini` and not via the Symfony Application. Commits ------- b29c212 [Session] Add docs to define redis session handler via php.ini directly
…o-org) This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Tip to not reconfigure system cache Add tip to not reconfigure system cache as per `@nicolas`-grekas [comment](symfony#12774 (comment)). Commits ------- aa67292 [Cache] Tip to not reconfigure system cache
…(tacman) This PR was submitted for the 6.1 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [DependencyInjection] Show how to get $myService Fixes symfony#17397, makes it clearer how to get the service, since ->get() isn't correct and getDefinition() isn't obvious. Commits ------- 95b8fea [DependencyInjection] Show how to get $myService
…ion (ThomasLandauer) This PR was merged into the 4.4 branch. Discussion ---------- [Doctrine] Adding caution box on dependecy injection I guessed this (based on trial and error), so please double-check! Maybe add a second sentence like: The reason is that the class is instantiated by Doctrine and not wired through Symfony's DI container. Commits ------- 806310a Adding caution box on dependecy injection
…ware` (Guikingone) This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead. Discussion ---------- [DependencyInjection][Framework] `kernel.locale_aware` Hi 👋🏻 It seems that the `kernel.locale_aware` tag was introduced in `4.3` without documenting it, here's a first draft. Thanks for the feedback 🙂 Commits ------- c1ab456 refactor(reference): document kernel.locale_aware
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Form][Form Choice] customize choice entry First PR here symfony#15921, but...something happened! I'm not sure where to add the link on the form_theme document, so I don't add it. And I'm not sure for the title **Access data in a Form Choice** `@HeahDude` Commits ------- 8a05949 [Form][Form Choice] customize choice entry
… hints (94noni) This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Serializer] Update serializer example using type hints Hi, small proposition to upgrade code example here in the serializer doc using type hint on object to serialize to make example more robust from the input to output Before continuing on this page, I want to ask if it is useful or not Thank you! Commits ------- fd73939 Update serializer.rst
…ype (MrYamous) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Form] fix EntityType with multiple=true return type Small fix for symfony#16805 about return type in form with multiple option I'm doing this on version 4.4 because it's the older maintained, but maybe we need to correct further? Commits ------- 0ad2d2f [Form] fix EntityType with multiple=true return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getParent()call in types inheritance mechanismConstraintssubdirectorycompressionoption from Redis and MemcacheCollectionreferenceCollectionreference symfony/symfony-docs#13492] satisfy the linterAPP_ENV=testbehaviorexcludeto PHP code samplecontrollerattribute in route definitionmessenger:stop-workerscommandexcluded_404stoexcluded_http_codesrender_restattributeThrowableResponse::HTTP_MOVED_PERMANENTLYfor redirectBuild the Documentation Locally_build/build.phpdiagnostics in 4.4fetchAllAssociativefor a result setpathinstead ofurlin SSI documentationgit://isn't supported by Github anymore.uses:end-before:,:start-after:as it's not used anymoremonolog.loggertologgerMicroKernelsectionChoiceTypeCSselectedchoicetest link