Skip to content

[Ldap] Update ldap.rst #15453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[Ldap] Update ldap.rst #15453

merged 1 commit into from
Jul 15, 2021

Conversation

jljohnstone
Copy link
Contributor

Add single quotes in filter option documentation

Add single quotes in filter option documentation
@OskarStark OskarStark added this to the 4.4 milestone Jun 22, 2021
@carsonbot carsonbot changed the title Update ldap.rst [Ldap] Update ldap.rst Jun 22, 2021
@javiereguiluz
Copy link
Member

Jason, thanks for this contribution!

Looking at https://github.com/symfony/symfony/blob/b617ee0cd014767fcf52971a9644d2f0bfbdf719/src/Symfony/Component/Ldap/Adapter/AbstractQuery.php#L43-L45 it seems that both strings and arrays are accepted. But I don't know LDAP much, so I'm not sure if 'foo, bar' is equivalent to ['foo', 'bar'] (maybe the first one means AND and the second one means OR?)

Let's ask to someone who knows LDAP well. Thanks!

@OskarStark
Copy link
Contributor

@jljohnstone can you confirm that the code before works as well? Or did you just spot this "issue" while reading the docs?

@jljohnstone
Copy link
Contributor Author

@OskarStark No, the documented code did not work for me. I had to use separate array elements to get filtering to work.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this in a Symfony functional test and I can confirm that this indeed needs to be an array.

@javiereguiluz
Copy link
Member

Jason, thanks a lot for fixing this ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit decb00b into symfony:5.4 Jul 15, 2021
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 15, 2021
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 15, 2021
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 15, 2021
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants