-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Ldap] Update ldap.rst #15453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ldap] Update ldap.rst #15453
Conversation
Add single quotes in filter option documentation
Jason, thanks for this contribution! Looking at https://github.com/symfony/symfony/blob/b617ee0cd014767fcf52971a9644d2f0bfbdf719/src/Symfony/Component/Ldap/Adapter/AbstractQuery.php#L43-L45 it seems that both strings and arrays are accepted. But I don't know LDAP much, so I'm not sure if Let's ask to someone who knows LDAP well. Thanks! |
@jljohnstone can you confirm that the code before works as well? Or did you just spot this "issue" while reading the docs? |
@OskarStark No, the documented code did not work for me. I had to use separate array elements to get filtering to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this in a Symfony functional test and I can confirm that this indeed needs to be an array.
Jason, thanks a lot for fixing this ... and congrats on your first Symfony Docs contribution 🎉 |
* 4.4: Backport symfony#15453 fix
* 5.2: Backport symfony#15453 fix
* 5.3: Backport symfony#15453 fix
Add single quotes in filter option documentation