[Form] Update create_form_type_extension.rst #16506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
approved these changes
Feb 14, 2022
yceruto
approved these changes
Feb 14, 2022
carsonbot
changed the title
Hello, I think the condition `image_url is not null` is not enough as if we create a FileType form field without the `image_property` it causes an error. Adding `image_url is defined` is necessary because the variable `image_url` is only defined and passed to the view when `image_property` is already defined.
|
Thanks Issam. |
javiereguiluz
force-pushed
the
patch-4
branch
from
762770c to
85470c5
Compare
xabbuh
pushed a commit
to xabbuh/symfony-docs
that referenced
this pull request
Mar 13, 2022
…amkhadiri1989) This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Form] Update create_form_type_extension.rst Hello, I think the condition `image_url is not null` is not enough as if we create a FileType form field without the `image_property` it causes an error. Adding `image_url is defined` is necessary because the variable `image_url` is only defined and passed to the view when `image_property` is already defined. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 85470c5 Update create_form_type_extension.rst
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 15, 2022
* 4.4: Add quotations marks minor symfony#16506 [Form] Update create_form_type_extension.rst (issamkhadiri1989)
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 15, 2022
* 5.4: Add quotations marks minor symfony#16506 [Form] Update create_form_type_extension.rst (issamkhadiri1989) Typo
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 15, 2022
* 6.0: Add quotations marks minor symfony#16506 [Form] Update create_form_type_extension.rst (issamkhadiri1989) Typo
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I think the condition
image_url is not nullis not enough as if we create a FileType form field without theimage_propertyit causes an error. Addingimage_url is definedis necessary because the variableimage_urlis only defined and passed to the view whenimage_propertyis already defined.