Skip to content

Add more details about the ESI detection #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #14640.

@OskarStark
Copy link
Contributor

Thank you Javier.

@OskarStark OskarStark merged commit 80369c8 into symfony:4.4 Jan 8, 2021
Symfony detects if a gateway cache supports ESI via another Akamai
specification that is supported out of the box by the Symfony reverse
proxy.
Symfony considers that a gateway cache supports ESI if its responses include
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in the request, not in the response

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! @OskarStark could you please update this in a direct merge in upstream? No need to make a PR for this. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done :-)

OskarStark added a commit that referenced this pull request Jan 8, 2021
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Jan 8, 2021
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Jan 8, 2021
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants