-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add more details about the ESI detection #14801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you Javier. |
Symfony detects if a gateway cache supports ESI via another Akamai | ||
specification that is supported out of the box by the Symfony reverse | ||
proxy. | ||
Symfony considers that a gateway cache supports ESI if its responses include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in the request, not in the response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! @OskarStark could you please update this in a direct merge in upstream? No need to make a PR for this. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done :-)
* 4.4: Minors. refs symfony#14801
* 5.1: Minors. refs symfony#14801
* 5.2: Minors. refs symfony#14801
Fixes #14640.