-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add note on composer update dependency mismatch #13710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On branches other that master or version branches (existing in Symfony repository) composer update command will fail, since those cannot be installed.
contributing/code/tests.rst
Outdated
@@ -24,6 +24,11 @@ tests, such as Doctrine, Twig and Monolog. To do so, | |||
|
|||
$ composer update | |||
|
|||
.. tip:: | |||
|
|||
You need to be on ``master`` or version branch (e.g. ``5.1``). Otherwise some dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would show the usage of the COMPOSER_ROOT_VERSION
env var instead like this:
COMPOSER_ROOT_VERSION=5.1.x-dev symfony composer update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know it works like that actually 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xabbux I changed the tip accordingly. Is the wording ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we shouldn't simply always make use of the env var and simply add a sentence like "replace 5.1 with the Symfony version your patch targets" or so.
This PR has been closed because the master has been removed. |
On branches other that master or version branches (existing in Symfony repository)
composer update
command will fail, since those cannot be installed.For example, when I've tried to run tests for Redis Messenger message rejection commit, I've got this error output (trimmed a little, and I was on a specific commit, but it happens on branches as well):
Figured I have to be on one of existing Symfony branches for the install to proceed, and once I've switched to
master
, I was good to go.Is the selected doc branch correct in this PR? Is the wording in the tip ok?