Skip to content

Add note on composer update dependency mismatch #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add note on composer update dependency mismatch #13710

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcdb75c
Add note on composer update required branch
Steveb-p May 27, 2020
39ed970
Fix typo
Steveb-p May 27, 2020
9e3d888
show COMPOSER_ROOT_VERSION
Steveb-p May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions contributing/code/tests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ tests, such as Doctrine, Twig and Monolog. To do so,

$ composer update

.. tip::

You need to be on ``master`` or version branch (e.g. ``5.1``). Otherwise some dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would show the usage of the COMPOSER_ROOT_VERSION env var instead like this:

COMPOSER_ROOT_VERSION=5.1.x-dev symfony composer update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it works like that actually 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbux I changed the tip accordingly. Is the wording ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't simply always make use of the env var and simply add a sentence like "replace 5.1 with the Symfony version your patch targets" or so.

might cause ``composer update`` command to fail.

.. _running:

Running the Tests
Expand Down