Skip to content

[Form] Add PHP Attributes example to forms #15001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

[Form] Add PHP Attributes example to forms #15001

merged 1 commit into from
Feb 22, 2021

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Feb 18, 2021

No description provided.

@wkania wkania requested a review from xabbuh as a code owner February 18, 2021 20:18
@OskarStark
Copy link
Contributor

Please check the CI, thanks

@wkania
Copy link
Contributor Author

wkania commented Feb 19, 2021

@OskarStark Look at CI error, it's related to
From what I understand, not my Pull request introduced this error.

@OskarStark
Copy link
Contributor

Indeed, can you please rebase?

@wkania
Copy link
Contributor Author

wkania commented Feb 19, 2021

Unlucky PR. Another error @OskarStark .

@xabbuh xabbuh added this to the 5.2 milestone Feb 21, 2021
@javiereguiluz
Copy link
Member

And another nice PR! Thanks a lot @wkania!

@javiereguiluz javiereguiluz merged commit f245120 into symfony:5.2 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@wkania @OskarStark @javiereguiluz @xabbuh @carsonbot