Skip to content

[HttpClient] Fix invalid file #15005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[HttpClient] Fix invalid file #15005

merged 1 commit into from
Feb 19, 2021

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Feb 19, 2021

@javiereguiluz, Small fix in your tweaks.

@carsonbot carsonbot added this to the 4.4 milestone Feb 19, 2021
@carsonbot carsonbot changed the title Fix invalid file [HttpClient] Fix invalid file Feb 19, 2021
@javiereguiluz javiereguiluz merged commit d6356eb into symfony:4.4 Feb 19, 2021
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 19, 2021

Thank you @wkania. Although your fix solved the problem, when we only display a PHP code listing, we don't use "configuration blocks". Instead, we use this -> 4e212ee

If a sentence ends with two : then the following indented lines are highlighted as PHP code. That's why we (almost) never have stand-alone .. code-block:: php

@wkania
Copy link
Contributor Author

wkania commented Feb 19, 2021

Good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants