Added the way to activate remember me in the new authentication system #15464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to search a while for myself not understanding why I did not have a REMEMBERME cookie when I activated the new system. So maybe handy to add it.
OskarStark
reviewed
Jul 15, 2021
| @@ -167,6 +167,27 @@ this: | |||
| The user will then automatically be logged in on subsequent visits while | |||
| the cookie remains valid. | |||
|
|
|||
| Beware that in the new Authenitaction System you have to set the RememberMeBadge() | |||
There was a problem hiding this comment.
Suggested change
| Beware that in the new Authenitaction System you have to set the RememberMeBadge() | |
| Beware that in the new authenitaction system you have to set the ``RememberMeBadge()`` |
OskarStark
reviewed
Jul 15, 2021
| @@ -167,6 +167,27 @@ this: | |||
| The user will then automatically be logged in on subsequent visits while | |||
| the cookie remains valid. | |||
|
|
|||
| Beware that in the new Authenitaction System you have to set the RememberMeBadge() | |||
| in the authenticate method of the authenticator, like: | |||
There was a problem hiding this comment.
Suggested change
| in the authenticate method of the authenticator, like: | |
| in the ``authenticate()`` method of the authenticator:: |
OskarStark
reviewed
Jul 15, 2021
Comment on lines
+173
to
+189
| .. code-block:: php | ||
|
|
||
| public function authenticate(Request $request): PassportInterface | ||
| { | ||
| $email = $request->request->get('email', ''); | ||
|
|
||
| $request->getSession()->set(Security::LAST_USERNAME, $email); | ||
|
|
||
| return new Passport( | ||
| new UserBadge($email), | ||
| new PasswordCredentials($request->request->get('password', '')), | ||
| [ | ||
| new CsrfTokenBadge('authenticate', $request->get('_csrf_token')), | ||
| new RememberMeBadge(), | ||
| ] | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| .. code-block:: php | |
| public function authenticate(Request $request): PassportInterface | |
| { | |
| $email = $request->request->get('email', ''); | |
| $request->getSession()->set(Security::LAST_USERNAME, $email); | |
| return new Passport( | |
| new UserBadge($email), | |
| new PasswordCredentials($request->request->get('password', '')), | |
| [ | |
| new CsrfTokenBadge('authenticate', $request->get('_csrf_token')), | |
| new RememberMeBadge(), | |
| ] | |
| ); | |
| } | |
| public function authenticate(Request $request): PassportInterface | |
| { | |
| $email = $request->request->get('email', ''); | |
| $request->getSession()->set(Security::LAST_USERNAME, $email); | |
| return new Passport( | |
| new UserBadge($email), | |
| new PasswordCredentials($request->request->get('password', '')), | |
| [ | |
| new CsrfTokenBadge('authenticate', $request->get('_csrf_token')), | |
| new RememberMeBadge(), | |
| ] | |
| ); | |
| } |
benjaminmal
reviewed
Oct 4, 2021
| @@ -167,6 +167,27 @@ this: | |||
| The user will then automatically be logged in on subsequent visits while | |||
| the cookie remains valid. | |||
|
|
|||
| Beware that in the new Authenitaction System you have to set the RememberMeBadge() | |||
There was a problem hiding this comment.
Little spelling error :)
Suggested change
| Beware that in the new Authenitaction System you have to set the RememberMeBadge() | |
| Beware that in the new authentication system you have to set the ``RememberMeBadge()`` |
|
Hi there! There has been some unfortunate delay with documenting the new remember me system. I've proposed a complete update of the remember docs now: #16376 I've cherry-picked your commit in that PR, as it's just me being late on this PR that avoided this commit to make it into the docs repo in the first place. |
wouterj
added a commit
that referenced
this pull request
Jan 19, 2022
…dojulien, parijke, wouterj) This PR was merged into the 5.3 branch. Discussion ---------- [Security] Document the new remember me system Fixes #15721, fixes #16149 Replaces #15464, replaces #15893 Ref #15908 In Symfony 5.3, along with the new authentication system, we also somewhat silently introduced a new remember me system. Time to update the remember me docs with all new features :) This PR also includes 2 commits from open PRs in this repository. We've been very late with this one, and community members have already invested time in contributing necessary changes to the docs before. They deserve the credits :) `@javiereguiluz` I'm sorry for not informing you of this work before, I see you just merged a third PR that is replaced by this one. Commits ------- 5ac2d26 Document the new remember me system 2df2275 Added the way to activate remember me in the new authentication system d36b949 Update remember_me.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to search a while for myself not understanding why I did not have a REMEMBERME cookie when I activated the new system. So maybe handy to add it.