[Live] Always send HTML over the wire instead of JSON #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Jan 24, 2022
| } | ||
|
|
||
| throw new Error(`The update() method could not be called for "${clonedElement.outerHTML}": the element must either have a "data-value" or "value" attribute set.`); | ||
| } |
There was a problem hiding this comment.
Unrelated bug fix from a feature I merged recently #203. That PR added this check, but it IS ok to have an empty value - it just means, for example, that a textarea is empty! For some reason, the tests didn't catch this before, but after this change, one test DID start failing.
kbond
approved these changes
Jan 24, 2022
weaverryan
force-pushed
the
use-html-across-wire
branch
from
28ff20e to
f18d797
Compare
Merged
kbond
added a commit
that referenced
this pull request
Feb 1, 2022
This PR was merged into the 2.x branch. Discussion ---------- Rebuild js dist files | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | N/A | License | MIT Tried to update my project deps to use 2-x.dev of LiveComponent, but now that renderer returns HTML instead of JSON, it fails, because the LiveController still uses JSON. This rebuilds dist files from #226, #245, #247 changes. Commits ------- 6906cc6 Rebuild js dist files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Currently, the LiveComponent controller expects to get JSON back from the server, containing
{ data: ..., html: '...' }. But, Stimulus is so cool, that this isn't necessary! The LiveComponent Ajax requests can simply return HTML in all cases. The rendered element will have an updateddata-live-data-valueattribute with the latest data. And so, the Stimulus component instantly reads that updated data and incorporates it: there is no need to send back the "component data" on a separate key in the JSON.This makes the live component system more boring in a good way: it's just a way to return HTML (and then we have fancy JavaScript that adds all the interactivity). It's also a bit faster now, as previously we were dehydrating the component data twice on re-render.
I can't think of any downsides to this approach - everything seems to work just fine.
Cheers!