Skip to content

Fix Typescript alerts #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix Typescript alerts #247

merged 1 commit into from
Jan 26, 2022

Conversation

tgalopin
Copy link
Contributor

Q A
Bug fix? yes
New feature? -
Tickets -
License MIT

Fix Typescript alerts in controllers.

@weaverryan
Copy link
Member

This is a big yay - thank you Titouan!

@weaverryan weaverryan merged commit c57eb55 into symfony:2.x Jan 26, 2022
@tgalopin tgalopin deleted the fix-ts-alerts branch January 26, 2022 18:35
@norkunas norkunas mentioned this pull request Feb 1, 2022
kbond added a commit that referenced this pull request Feb 1, 2022
This PR was merged into the 2.x branch.

Discussion
----------

Rebuild js dist files

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | N/A
| License       | MIT

Tried to update my project deps to use 2-x.dev of LiveComponent, but now that renderer returns HTML instead of JSON, it fails, because the LiveController still uses JSON.

This rebuilds dist files from #226, #245, #247 changes.

Commits
-------

6906cc6 Rebuild js dist files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants