-
Notifications
You must be signed in to change notification settings - Fork 184
Builds failing due to semver violation in Zip #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ddimaria is there any workaround if I have a dependancy that uses calamine? how can I pin the version of zip? the [replace]
"zip:2.6.0" = { git = "https://github.com/zip-rs/zip2", rev = "v2.5.0" } leads to:
sorry if this is out of scope... asking that because of your workaround suggestion |
@itaysmalia maybe try replacing the version number with the commit hash: |
@ddimaria thanks! |
Fix if anyone needs it: zip-rs/zip2#332 (comment) |
any progress? |
an other easier fix than cloning would be to just cargo update -p zip --precise 2.5.0 |
For those who might be experiencing build issues, here’s a summary of possible workarounds: 1. Temporary solutionFor now, doing the following fixes it: $ cargo update -p zip --precise 2.5.0 But it'll break again if you run 2. Patch dependency version# Cargo.toml
[patch.crates-io]
zip = { git = "https://github.com/zip-rs/zip2", tag = "v2.5.0" } Due to a limitation in Cargo (rust-lang/cargo#5478), we unfortunately can’t use the crates.io index when changing dependency versions. As a result, we had to use the git protocol. 3. Patch dependency version (registry)For those who prefer not to use the # Cargo.toml
[patch.crates-io]
zip = { version = "=2.5.0", registry = "crates-io-2" } # .cargo/config.toml
[registries]
crates-io-2 = { index = "sparse+https://index.crates.io/" }
# Required due to https://github.com/rust-lang/cargo/issues/5478 This can lead to the same sub-dependency being downloaded from both crates-io and crates-io-2. It’s not a major issue to download the same dependency twice, but just be aware of it. |
Is this project no longer maintained? |
Issue in Zip: zip-rs/zip2#332
The workaround is to fix calamine to version 2.5.0 of Zip in Cargo.toml.
The text was updated successfully, but these errors were encountered: