Don't break due to our handles getting closed by FD redirection

[segevfiner]

The fix is to simply not cache the std handles returned by GetStdHandle

This happens in Pytest on at least Python 3.5 and 3.6.
Please check pytest-dev/pytest#2465 for more information about this before merging.

[wiggin15]

This could be related to #114 and maybe #104 (comment) is also slightly related

[segevfiner]

Arghhhh, I started seeing this on Python 2.7 too. Who knows what changed that it's now triggered there too. Be it Pytest version, Windows version, or what not... This PR seems to fix it for that instance too, anyhow.

I still find the fact that this is random completely baffling... 😕

[Victorious3]

I would love to see this one fixed as well, ran into it when using pytest.

[nicoddemus]

I would love to see this one fixed as well, ran into it when using pytest.

I second that. @wiggin15 anything missing here? Anything else we can help with to get this merged and a new PyPI release?

[nicoddemus]

Great, thanks a lot @wiggin15!

[wiggin15]

Just to make sure - is the problem in pytest related to stream redirection?
Any chance you can summarize the problem in one sentence for the changelog - something like "don't cache the std handles to avoid problems where/with ..."
Thanks.

[segevfiner]

Just to make sure - is the problem in pytest related to stream redirection?
Any chance you can summarize the problem in one sentence for the changelog - something like "don't cache the std handles to avoid problems where/with ..."
Thanks.

Yes. It is caused by FD redirection (dup2). Windows is closing the underlying handle and they don't always end up with the same number when reopened. Maybe something like: "Don't cache stdio HANDLEs, since they might be closed/changed by fd redirection".

[wiggin15]

Thanks. There's a new release, 0.4.0, with this change.

[nicoddemus]

Awesome, thanks @wiggin15 for the prompt merge and release! 🙇