Early import colorama so that it get's the correct terminal #2611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This fixes #2510. |
|
Just tested it and it fixes the problem wonderfully. Awesome job! |
|
Updated the CHANGELOG message to point to #2510 and re-worded it for a more user-oriented description. As soon as CI passes we can merge this. 😁 |
RonnyPfannschmidt
approved these changes
Jul 24, 2017
The-Compiler
requested changes
Jul 24, 2017
_pytest/capture.py
Outdated
| """ | ||
| Ensure colorama is imported so that it attaches to the correct stdio | ||
| handles on Windows. | ||
|
|
There was a problem hiding this comment.
The trailing whitespace here breaks the linting environment 😉
There was a problem hiding this comment.
Thank you GitHub web editor 😝
nicoddemus
approved these changes
Jul 24, 2017
The-Compiler
approved these changes
Jul 24, 2017
|
🎆 |
|
I just wanted to say thanks again for fixing this - I finally can use pytest with colors on Windows! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had it print ANSI escapes without stripping or conversion. With tartley/colorama#131 it captures the wrong default terminal attributes so that the default text color is black (colorama doesn't check for errors).
Importing colorama in a conftest.py should reproduce this.
$issue_id.$typefor example (588.bug)removal,feature,bugfix,vendor,docortrivialbugfix,vendor,docortrivialfixes, targetmaster; for removals or features targetfeatures;Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS;