Normative: Move numberingSystem before style in resolvedOptions#172
Merged
Normative: Move numberingSystem before style in resolvedOptions#172
Conversation
ryzokuken
approved these changes
Sep 7, 2023
Member
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
Change and rationale LGTM. Does this reflect the plenary consensus or does this need to be raised again?
Collaborator
anba
approved these changes
Sep 8, 2023
Member
|
Perfect, will mark this and present it in plenary next. |
ryzokuken
added
consensus
Collaborator
Author
It need to be raised in plenary. That is exactly why I create this PR to make sure it went through proper process. |
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Sep 9, 2023
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Sep 9, 2023
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting
Collaborator
Author
|
test PR tc39/test262#3912 |
Collaborator
Author
|
@ben-allen @sffc @ryzokuken This is discussed and agreed in TG2 in 2023-09-07 but we need someone to bring this up to TG1 in Nov 2023 before this can be merged. |
Member
|
2023-11-28: This PR achieved TC39-TG1 consensus. |
Member
|
@FrankYFTang could you please rebase this? Let's get this merged. |
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Apr 10, 2024
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Apr 10, 2024
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting Swap actual/expected order Update test/intl402/DurationFormat/constructor-option-read-order.js Co-authored-by: André Bargull <andre.bargull@gmail.com> Fix per anba suggestion
ptomato
pushed a commit
to FrankYFTang/test262
that referenced
this pull request
Jul 24, 2024
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting Swap actual/expected order Update test/intl402/DurationFormat/constructor-option-read-order.js Co-authored-by: André Bargull <andre.bargull@gmail.com> Fix per anba suggestion
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Jul 24, 2024
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting Swap actual/expected order Update test/intl402/DurationFormat/constructor-option-read-order.js Co-authored-by: André Bargull <andre.bargull@gmail.com> Fix per anba suggestion
webkit-commit-queue
pushed a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Sep 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=279940 Reviewed by Yusuke Suzuki. This patch makes the following changes to update `Intl.DurationFormat.prototype.resolvedOptions` to the latest spec: - Does not put `fractionalDigits` when it is `undefined`[1] - Put `numberingSystem` before `style`[2] [1]: tc39/proposal-intl-duration-format#167 [2]: tc39/proposal-intl-duration-format#172 * Source/JavaScriptCore/runtime/IntlDurationFormat.cpp: (JSC::IntlDurationFormat::resolvedOptions const): * JSTests/test262/expectations.yaml: * JSTests/stress/intl-durationformat.js: (test): Canonical link: https://commits.webkit.org/283901@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #163
See the proposed action and reason by @anba in #163 (comment)